Sign upLogin

JordanRL/Fermat

View on GitHub
Star

Showing 27 of 52 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if ($this instanceof Decimal) {
            $value = Numbers::makeOrDont(Numbers::IMMUTABLE, $value, $this->getScale());

            if ($this->compare($value) === -1) {
                return true;
Severity: Major
Found in src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php and 4 other locations - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 28..44
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 58..78
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 92..112
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 178..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if ($this instanceof Decimal) {
            $value = Numbers::makeOrDont(Numbers::IMMUTABLE, $value, $this->getScale());

            if ($this->compare($value) > -1) {
                return true;
Severity: Major
Found in src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php and 4 other locations - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 28..44
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 58..78
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 144..164
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 178..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if ($this instanceof Decimal) {
            $value = Numbers::makeOrDont(Numbers::IMMUTABLE, $value, $this->getScale());

            return $this->isEqualDecimal($value);
        } else {
Severity: Major
Found in src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php and 4 other locations - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 58..78
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 92..112
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 144..164
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 178..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            $realPart = match (true) {
                $partThis instanceof Fraction => match (true) {
                    $compareTo instanceof Fraction => self::normalizeObject($partThis, $mode, $scale),
                    default => self::normalizeObject($partThis->asDecimal(), $mode, $scale)
                },
Severity: Minor
Found in src/Samsara/Fermat/Core/Types/Traits/NumberNormalizationTrait.php and 1 other location - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/NumberNormalizationTrait.php on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if ($this instanceof Decimal) {
            $value = Numbers::makeOrDont(Numbers::IMMUTABLE, $value, $this->getScale());

            if ($this->compare($value) === 1) {
                return true;
Severity: Major
Found in src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php and 4 other locations - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 28..44
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 92..112
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 144..164
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 178..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if ($this instanceof Decimal) {
            /** @var ImmutableDecimal $value */
            $value = Numbers::makeOrDont(Numbers::IMMUTABLE, $value, $this->getScale());

            if ($this->compare($value) < 1) {
Severity: Major
Found in src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php and 4 other locations - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 28..44
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 58..78
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 92..112
src/Samsara/Fermat/Core/Types/Traits/ComparisonTrait.php on lines 144..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            $imaginaryPart = match (true) {
                $partThis instanceof Fraction => match (true) {
                    $compareTo instanceof Fraction => self::normalizeObject($partThis, $mode, $scale),
                    default => self::normalizeObject($partThis->asDecimal(), $mode, $scale)
                },
Severity: Minor
Found in src/Samsara/Fermat/Core/Types/Traits/NumberNormalizationTrait.php and 1 other location - About 40 mins to fix
src/Samsara/Fermat/Core/Types/Traits/NumberNormalizationTrait.php on lines 122..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language