Sign upLogin

JuanitoFatas/comer_de_tapas

View on GitHub
Star

Showing 3 of 3 total issues

Class Client has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client

    # Initialize comer de tapas
    # $ mkdir -p ~/.rubytapas/
    # $ touch ~/.rubytapas/.credentials
Severity: Minor
Found in lib/comer_de_tapas/client.rb - About 2 hrs to fix

    Method download_all_tapas! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def download_all_tapas!
        episodes.each do |episode|
          FileUtils.cd(save_folder) do
            episode_title = episode["title"]
            puts "Downloading Epsiode #{episode_title}..."
    Severity: Minor
    Found in lib/comer_de_tapas/client.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method credential_data_valid? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def credential_data_valid? data
        data.each do |hash|
          hash.each do |k,v|
            abort <<-MSG unless KEYS.include? k
Probably have a typo in #{CREDENTIAL_FILE}: #{k}
    Severity: Minor
    Found in lib/comer_de_tapas/subscription.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language