JumpstartLab/tracks

View on GitHub

Showing 182 of 244 total issues

Function setup_behavior has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setup_behavior: function() {
        /* Add note */
        $(document).on("click",".add_note_link a", function(){
            $('#new-note').show();
            $('textarea#note_body').val('');
Severity: Minor
Found in app/assets/javascripts/tracks.js - About 1 hr to fix

    Method defer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def defer
        @source_view = params['_source_view'] || 'todo'
        numdays = params['days'].to_i
    
        @todo = current_user.todos.find(params[:id])
    Severity: Minor
    Found in app/controllers/todos_controller.rb - About 1 hr to fix

      Method should_show_new_item has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def should_show_new_item
          source_view do |page|
            page.todo { return !@todo.hidden? }
            page.deferred { return @todo.deferred? || @todo.pending? }
            page.context {
      Severity: Minor
      Found in app/helpers/todos_helper.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_needs_to_hide_context has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_needs_to_hide_context
          return (@remaining_in_context == 0 && (@todo_hidden_state_changed && @todo.hidden?)) ||
            (@remaining_in_context == 0 && @todo_was_deferred_from_active_state) ||
            (@remaining_in_context == 0 && @tag_was_removed) ||
            (@remaining_in_context == 0 && @todo.completed? && !(@original_item_was_deferred || @original_item_was_hidden)) if source_view_is(:tag)
      Severity: Minor
      Found in app/helpers/todos_helper.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save_predecessors has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def save_predecessors
          unless @predecessor_array.nil?  # Only save predecessors if they changed
            current_array = self.predecessors
            remove_array = current_array - @predecessor_array
            add_array = @predecessor_array - current_array
      Severity: Minor
      Found in app/models/todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_monthly has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def validate_monthly
          case recurrence_selector
          when 0 # 'monthly_every_x_day'
            errors[:base] << "The day of the month may not be empty for recurrence setting" if monthly_every_x_day.blank?
            errors[:base] << "Every other nth month may not be empty for recurrence setting" if monthly_every_x_month.blank?
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_yearly_date has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_yearly_date(previous)
          start = determine_start(previous)
          day = self.every_other1
          month = self.every_other2
      
      
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_yearly has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def validate_yearly
          case recurrence_selector
          when 0 # 'yearly_every_x_day'
            errors[:base] << "The month of the year may not be empty for recurrence setting" if yearly_month_of_year.blank?
            errors[:base] << "The day of the month may not be empty for recurrence setting" if yearly_every_x_day.blank?
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method determine_completed_count has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def determine_completed_count
          source_view do |from|
            from.todo do
              @completed_count = current_user.todos.not_hidden.completed.count
            end
      Severity: Minor
      Found in app/controllers/todos_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method set_session_expiration has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def set_session_expiration
          # http://wiki.rubyonrails.com/rails/show/HowtoChangeSessionOptions
          unless session == nil
            return if self.controller_name == 'feed' or session['noexpiry'] == "on"
            # If the method is called by the feed controller (which we don't have
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize
            @options = {}
            @keywords = {}
      
            @parser = OptionParser.new do |cmd|
      Severity: Minor
      Found in doc/tracks_template_cli.rb - About 1 hr to fix

        Method due_date has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def due_date(due)
            return "" if due.nil?
        
            days = days_from_today(due)
        
        
        Severity: Minor
        Found in app/helpers/application_helper.rb - About 1 hr to fix

          Method determine_down_count has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def determine_down_count
              source_view do |from|
                from.todo do
                  @down_count = current_user.todos.active.not_hidden.count
                end
          Severity: Minor
          Found in app/controllers/todos_controller.rb - About 1 hr to fix

            Method login has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def login
                @page_title = "TRACKS::Login"
                cookies[:preferred_auth] = prefered_auth? unless cookies[:preferred_auth]
                case request.method
                when 'POST'
            Severity: Minor
            Found in app/controllers/login_controller.rb - About 1 hr to fix

              Method post has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def post(lines, options = {})
                    uri = URI.parse(GTD_URI)
                    http = Net::HTTP.new(uri.host, uri.port)
              
                    if uri.scheme == "https"  # enable SSL/TLS
              Severity: Minor
              Found in doc/tracks_cli_client.rb - About 1 hr to fix

                Method determine_start has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  def determine_start(previous, offset=0.day)
                
                    if previous.nil?
                      start = self.start_from.nil? ? Time.zone.now : self.start_from
                      # skip to present
                Severity: Minor
                Found in app/models/recurring_todo.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function project_defaults has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                function project_defaults(){
                    if($('body').hasClass('contexts')){
                    // don't change the context
                    // see ticket #934
                    } else {
                Severity: Minor
                Found in app/assets/javascripts/tracks.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  def create
                    p = RecurringTodoCreateParamsHelper.new(params)
                    p.attributes['end_date']=parse_date_per_user_prefs(p.attributes['end_date'])
                    p.attributes['start_from']=parse_date_per_user_prefs(p.attributes['start_from'])
                
                
                Severity: Minor
                Found in app/controllers/recurring_todos_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method set_locale has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  def set_locale
                    locale = params[:locale] # specifying a locale in the request takes precedence
                    locale = locale || prefs.locale unless current_user.nil? # otherwise, the locale of the currently logged in user takes over
                    locale = locale || request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first if request.env['HTTP_ACCEPT_LANGUAGE']
                    I18n.locale = locale.nil? ? I18n.default_locale : (I18n::available_locales.include?(locale.to_sym) ? locale : I18n.default_locale)
                Severity: Minor
                Found in app/controllers/application_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function default_ajax_options_for_submit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function default_ajax_options_for_submit(ajax_type, element_to_block) {
                    // the complete is not a function but an array so you can push other
                    // functions that will be executed after the ajax call completes
                    var options = {
                        type: ajax_type,
                Severity: Minor
                Found in app/assets/javascripts/tracks.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language