Kalkuli/2018.2-Kalkuli_Front-End

View on GitHub
src/components/UI/Button/MenuButton/MenuButton.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render () {
        let styleMenuButton = ["menubutton button"]
        this.state.rotate ? styleMenuButton.push("rotate menubutton--open") : null
       
        let styleOptions = ["options"]
Severity: Minor
Found in src/components/UI/Button/MenuButton/MenuButton.js - About 1 hr to fix

    Expected an assignment or function call and instead saw an expression.
    Open

            this.state.rotate ? styleMenuButton.push("rotate menubutton--open") : null

    Disallow Unused Expressions (no-unused-expressions)

    An unused expression which has no effect on the state of the program indicates a logic error.

    For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

    Rule Details

    This rule aims to eliminate unused expressions which have no effect on the state of the program.

    This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

    var i = 0;
    function increment() { i += 1; }
    increment(); // return value is unused, but i changed as a side effect
    
    var nThings = 0;
    function Thing() { nThings += 1; }
    new Thing(); // constructed object is unused, but nThings changed as a side effect

    This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

    Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

    Options

    This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

    • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
    • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
    • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

    These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

    Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

    /*eslint no-unused-expressions: "error"*/
    
    0
    
    if(0) 0
    
    {0}
    
    f(0), {}
    
    a && b()
    
    a, b()
    
    c = a, b;
    
    a() && function namedFunctionInExpressionContext () {f();}
    
    (function anIncompleteIIFE () {});
    
    injectGlobal`body{ color: red; }`

    Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

    "use strict";
    "use asm"
    "use stricter";
    "use babel"
    "any other strings like this in the prologue";

    Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

    /*eslint no-unused-expressions: "error"*/
    
    {} // In this context, this is a block statement, not an object literal
    
    {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
    
    function namedFunctionDeclaration () {}
    
    (function aGenuineIIFE () {}());
    
    f()
    
    a = 0
    
    new C
    
    delete a.b
    
    void a

    allowShortCircuit

    Examples of incorrect code for the { "allowShortCircuit": true } option:

    /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
    
    a || b

    Examples of correct code for the { "allowShortCircuit": true } option:

    /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
    
    a && b()
    a() || (b = c)

    allowTernary

    Examples of incorrect code for the { "allowTernary": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
    
    a ? b : 0
    a ? b : c()

    Examples of correct code for the { "allowTernary": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
    
    a ? b() : c()
    a ? (b = c) : d()

    allowShortCircuit and allowTernary

    Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

    /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
    
    a ? b() || (c = d) : e()

    allowTaggedTemplates

    Examples of incorrect code for the { "allowTaggedTemplates": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
    
    `some untagged template string`;

    Examples of correct code for the { "allowTaggedTemplates": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
    
    tag`some tagged template string`;

    Source: http://eslint.org/docs/rules/

    Expected an assignment or function call and instead saw an expression.
    Open

            !this.state.clickedMenuButton ? this.setState({clickedMenuButton: true}) : null

    Disallow Unused Expressions (no-unused-expressions)

    An unused expression which has no effect on the state of the program indicates a logic error.

    For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

    Rule Details

    This rule aims to eliminate unused expressions which have no effect on the state of the program.

    This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

    var i = 0;
    function increment() { i += 1; }
    increment(); // return value is unused, but i changed as a side effect
    
    var nThings = 0;
    function Thing() { nThings += 1; }
    new Thing(); // constructed object is unused, but nThings changed as a side effect

    This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

    Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

    Options

    This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

    • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
    • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
    • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

    These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

    Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

    /*eslint no-unused-expressions: "error"*/
    
    0
    
    if(0) 0
    
    {0}
    
    f(0), {}
    
    a && b()
    
    a, b()
    
    c = a, b;
    
    a() && function namedFunctionInExpressionContext () {f();}
    
    (function anIncompleteIIFE () {});
    
    injectGlobal`body{ color: red; }`

    Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

    "use strict";
    "use asm"
    "use stricter";
    "use babel"
    "any other strings like this in the prologue";

    Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

    /*eslint no-unused-expressions: "error"*/
    
    {} // In this context, this is a block statement, not an object literal
    
    {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
    
    function namedFunctionDeclaration () {}
    
    (function aGenuineIIFE () {}());
    
    f()
    
    a = 0
    
    new C
    
    delete a.b
    
    void a

    allowShortCircuit

    Examples of incorrect code for the { "allowShortCircuit": true } option:

    /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
    
    a || b

    Examples of correct code for the { "allowShortCircuit": true } option:

    /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
    
    a && b()
    a() || (b = c)

    allowTernary

    Examples of incorrect code for the { "allowTernary": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
    
    a ? b : 0
    a ? b : c()

    Examples of correct code for the { "allowTernary": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
    
    a ? b() : c()
    a ? (b = c) : d()

    allowShortCircuit and allowTernary

    Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

    /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
    
    a ? b() || (c = d) : e()

    allowTaggedTemplates

    Examples of incorrect code for the { "allowTaggedTemplates": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
    
    `some untagged template string`;

    Examples of correct code for the { "allowTaggedTemplates": true } option:

    /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
    
    tag`some tagged template string`;

    Source: http://eslint.org/docs/rules/

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        <div className="options__element">
                            <p className="options__element--text">Nova Nota</p>
                            <span className="options__element--circle button" onClick={this.onNewReceiptHandler}>
                                <img src={imgReceipt} alt="nota fiscal"/>
                            </span>            
    Severity: Major
    Found in src/components/UI/Button/MenuButton/MenuButton.js and 1 other location - About 2 hrs to fix
    src/components/UI/Button/MenuButton/MenuButton.js on lines 43..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        <div className="options__element">
                            <p className="options__element--text">Novo Relatório</p>
                            <span className="options__element--circle button" onClick={this.onNewReportHandler}>
                                <img src={imgReport} alt="relatorio"/>
                            </span>
    Severity: Major
    Found in src/components/UI/Button/MenuButton/MenuButton.js and 1 other location - About 2 hrs to fix
    src/components/UI/Button/MenuButton/MenuButton.js on lines 37..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    export const mapDispatchToProps = dispatch => {
        return {
            onReceiptsAdded: (receipts) => dispatch({type: actionTypes.ADD_RECEIPTS, receipts: receipts}) 
        }
    }
    Severity: Minor
    Found in src/components/UI/Button/MenuButton/MenuButton.js and 2 other locations - About 40 mins to fix
    src/components/UI/Navbar/HomeNavBar/HomeNavBar.js on lines 158..162
    src/App.js on lines 52..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status