Sign upLogin

KarrLab/datanator_frontend

View on GitHub
Star
src/components/SearchForm/SearchForm.js

Summary

Maintainability
D
1 day
Test Coverage
A
98%

Function render has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const entityTooltip = (
      <div>
        <p>
          Enter the id or name of a metabolite, gene, or reaction to search for
Severity: Major
Found in src/components/SearchForm/SearchForm.js - About 4 hrs to fix

    File SearchForm.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { Component } from "react";
import PropTypes from "prop-types";
import { withRouter } from "react-router-dom";

import { InputGroup } from "@blueprintjs/core";
    Severity: Minor
    Found in src/components/SearchForm/SearchForm.js - About 2 hrs to fix

      Function getMatchingOrganisms has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getMatchingOrganisms(query, event) {
    // Blueprint appears to issue two calls per input change; ignore the one with no defined event
    if (!event) {
      return;
    }
      Severity: Minor
      Found in src/components/SearchForm/SearchForm.js - About 1 hr to fix

        Function updateStateFromLocation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          updateStateFromLocation() {
    if (this.unlistenToHistory) {
      const route = parseHistoryLocationPathname(this.props.history);
      if (
        route.route === "search" &&
        Severity: Minor
        Found in src/components/SearchForm/SearchForm.js - About 1 hr to fix

          Function updateStateFromLocation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            updateStateFromLocation() {
    if (this.unlistenToHistory) {
      const route = parseHistoryLocationPathname(this.props.history);
      if (
        route.route === "search" &&
          Severity: Minor
          Found in src/components/SearchForm/SearchForm.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                <div>
        <p>
          Use this suggestion box to select a taxon such as &ldquo;Homo
          sapiens&rdquo;, &ldquo;E. coli&rdquo;, or &ldquo;Bacillus&rdquo; to
          find relevant data about.
          Severity: Major
          Found in src/components/SearchForm/SearchForm.js and 1 other location - About 1 hr to fix
          src/scenes/Help/Tutorial.js on lines 71..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            componentDidMount() {
    this.unlistenToHistory = this.props.history.listen(() => {
      this.updateStateFromLocation();
    });
    this.updateStateFromLocation();
          Severity: Major
          Found in src/components/SearchForm/SearchForm.js and 1 other location - About 1 hr to fix
          src/scenes/SearchResults/SearchResults.js on lines 26..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

            componentWillUnmount() {
    this.unlistenToHistory();
    this.unlistenToHistory = null;
    if (this.cancelTokenSource) {
      this.cancelTokenSource.cancel();
          Severity: Major
          Found in src/components/SearchForm/SearchForm.js and 2 other locations - About 55 mins to fix
          src/scenes/BiochemicalEntityDetails/Metabolite/SearchResultsList.js on lines 51..57
          src/scenes/SearchResults/SearchResultsList.js on lines 51..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status