Sign upLogin

KarrLab/datanator_frontend

View on GitHub
Star
src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js

Summary

Maintainability
F
3 days
Test Coverage
B
82%

File DataTable.js has 433 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from "react";
import { withRouter } from "react-router";
import PropTypes from "prop-types";
import axios from "axios";
import { getDataFromApi, genApiErrorHandler } from "~/services/RestApi";
Severity: Minor
Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 6 hrs to fix

    Function getDataFromApi has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      getDataFromApi() {
    const route = parseHistoryLocationPathname(this.props.history);
    const query = route.query;
    const organism = route.organism;
    Severity: Major
    Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 2 hrs to fix

      Function render has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
    if (DataTable.shouldTableRender(this.state.data)) {
      return (
        <div className="content-block" id={this.props.id}>
          <div className="content-block-heading-container">
      Severity: Major
      Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 2 hrs to fix

        Function calcTaxonomicDistance has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static calcTaxonomicDistance(taxonDistance, targetSpecies, measuredSpecies) {
    let distance = null;

    targetSpecies = targetSpecies.toLowerCase();
    measuredSpecies = measuredSpecies.toLowerCase();
        Severity: Minor
        Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 1 hr to fix

          Function calcTaxonomicDistance has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            static calcTaxonomicDistance(taxonDistance, targetSpecies, measuredSpecies) {
    let distance = null;

    targetSpecies = targetSpecies.toLowerCase();
    measuredSpecies = measuredSpecies.toLowerCase();
          Severity: Minor
          Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function calcTaxonomicRanks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            static calcTaxonomicRanks(organismData) {
    const ranks = [];
    for (let iLineage = 0; iLineage < organismData.length; iLineage++) {
      const lineage = organismData[iLineage];
      let rank;
          Severity: Minor
          Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function formatData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            formatData(rawData, organismData) {
    let taxonomicRanks = [];
    if (organismData) {
      taxonomicRanks = DataTable.calcTaxonomicRanks(organismData);
    }
          Severity: Minor
          Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 1 hr to fix

            Function calcTaxonomicRanks has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              static calcTaxonomicRanks(organismData) {
    const ranks = [];
    for (let iLineage = 0; iLineage < organismData.length; iLineage++) {
      const lineage = organismData[iLineage];
      let rank;
            Severity: Minor
            Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 1 hr to fix

              Function numericComparator has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                static numericComparator(valueA, valueB) {
    if (valueA == null) {
      if (valueB == null) {
        return 0;
      } else {
              Severity: Minor
              Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                componentDidMount() {
    this.locationPathname = this.props.history.location.pathname;
    this.unlistenToHistory = this.props.history.listen((location) => {
      if (location.pathname !== this.locationPathname) {
        this.locationPathname = this.props.history.location.pathname;
              Severity: Major
              Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js and 1 other location - About 4 hrs to fix
              src/scenes/BiochemicalEntityDetails/MetadataSection.js on lines 30..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 134.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (
          "response" in error &&
          error.response !== undefined &&
          "request" in error.response &&
          error.response.request.constructor.name === "XMLHttpRequest"
              Severity: Major
              Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js and 1 other location - About 3 hrs to fix
              src/scenes/BiochemicalEntityDetails/MetadataSection.js on lines 152..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 114.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                componentWillUnmount() {
    this.unlistenToHistory();
    this.unlistenToHistory = null;
    if (this.queryCancelTokenSource) {
      this.queryCancelTokenSource.cancel();
              Severity: Major
              Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js and 1 other location - About 2 hrs to fix
              src/scenes/BiochemicalEntityDetails/MetadataSection.js on lines 41..50

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 79.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  axios
      .all([
        getDataFromApi(url, {
          cancelToken: this.queryCancelTokenSource.token,
        }),
              Severity: Major
              Found in src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js and 1 other location - About 1 hr to fix
              src/scenes/BiochemicalEntityDetails/MetadataSection.js on lines 102..150

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status