Sign upLogin

KarrLab/datanator_frontend

View on GitHub
Star
src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js

Summary

Maintainability
F
5 days
Test Coverage
F
59%

Function processDescriptionFromUniprot has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

  static processDescriptionFromUniprot(query, data) {
    if (data == null || data.length === 0) {
      return MetadataSection.blankResponse;
    }
Severity: Minor
Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MetadataSection.js has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from "react";
import PropTypes from "prop-types";
import { Link } from "react-router-dom";
import BaseMetadataSection from "../MetadataSection";
import { LoadExternalContent, LoadContent } from "../LoadContent";
Severity: Minor
Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 5 hrs to fix

    Function processDescriptionFromUniprot has 129 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static processDescriptionFromUniprot(query, data) {
    if (data == null || data.length === 0) {
      return MetadataSection.blankResponse;
    }
    Severity: Major
    Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 5 hrs to fix

      Function formatMetadata has 101 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static formatMetadata(query, organism, processedData) {
    const sections = [];

    sections.push({
      id: "id",
      Severity: Major
      Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 4 hrs to fix

        Function processRelatedReactions has 76 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static processRelatedReactions(organism, relatedReactions) {
    const formattedResults = [];

    for (const reaction of relatedReactions) {
      const id = reaction.kinlaw_id;
        Severity: Major
        Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 3 hrs to fix

          Function processRelatedReactions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            static processRelatedReactions(organism, relatedReactions) {
    const formattedResults = [];

    for (const reaction of relatedReactions) {
      const id = reaction.kinlaw_id;
          Severity: Minor
          Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      if (datum.gene[0].olnNames[0].value) {
              geneName = datum.gene[0].olnNames[0].value;
            } else if (
              datum.gene[0].olnNames[0].evidences &&
              datum.gene[0].olnNames[0].evidences.length
          Severity: Major
          Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 45 mins to fix

            Function formatMetadata has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              static formatMetadata(query, organism, processedData) {
    const sections = [];

    sections.push({
      id: "id",
            Severity: Minor
            Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    <ul className="key-value-list link-list">
          {crossRefs.map((desc) => {
            return (
              <li key={desc.key}>
                <b>{desc.key}</b>: {desc.value}
            Severity: Major
            Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js and 1 other location - About 2 hrs to fix
            src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js on lines 148..156

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        <ul className="key-value-list link-list">
              {properties.map((property) => {
                return (
                  <li key={property.key}>
                    <b>{property.key}</b>: {property.value}
            Severity: Major
            Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js and 1 other location - About 2 hrs to fix
            src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js on lines 403..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              render() {
    return (
      <BaseMetadataSection
        entity-type="ortholog group"
        get-metadata-url={this.getMetadataUrl}
            Severity: Major
            Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js and 1 other location - About 2 hrs to fix
            src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js on lines 409..420

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 81.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (processedData.orthoDbId != null) {
      crossRefs.push({
        key: "OrthoDB",
        value: (
          <a
            Severity: Major
            Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js and 1 other location - About 1 hr to fix
            src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js on lines 383..397

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (processedData.uniprotId != null) {
      crossRefs.push({
        key: "UniProt",
        value: (
          <a
            Severity: Major
            Found in src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js and 1 other location - About 1 hr to fix
            src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js on lines 363..382

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status