Sign upLogin

KarrLab/datanator_frontend

View on GitHub
Star
src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js

Summary

Maintainability
F
4 days
Test Coverage
A
96%

Function formatMetadata has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static formatMetadata(query, organism, processedData) {
    const sections = [];

    sections.push({
      id: "id",
Severity: Major
Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js - About 6 hrs to fix

    File MetadataSection.js has 392 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { Component } from "react";
import PropTypes from "prop-types";
import { formatChemicalFormula, strCompare, castToArray } from "~/utils/utils";
import BaseMetadataSection from "../MetadataSection";
import LazyLoad from "react-lazyload";
    Severity: Minor
    Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js - About 5 hrs to fix

      Function processMetadata has 132 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static processMetadata(query, organism, rawData) {
    let processedData = {};
    const met = rawData;
    processedData = {};
    processedData.synonyms = null;
      Severity: Major
      Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js - About 5 hrs to fix

        Function processMetadata has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

          static processMetadata(query, organism, rawData) {
    let processedData = {};
    const met = rawData;
    processedData = {};
    processedData.synonyms = null;
        Severity: Minor
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function formatMetadata has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

          static formatMetadata(query, organism, processedData) {
    const sections = [];

    sections.push({
      id: "id",
        Severity: Minor
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              processedData.description = reactStringReplace(
        processedData.description,
        /[([]PMID:? *(\d+)[)\]]/gi,
        (pmid) => {
          return (
        Severity: Major
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js and 1 other location - About 2 hrs to fix
        src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js on lines 152..170

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              processedData.description = reactStringReplace(
        processedData.description,
        /[([]Biocyc *(.*?)[)\]]/gi,
        (id) => {
          return (
        Severity: Major
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js and 1 other location - About 2 hrs to fix
        src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js on lines 115..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          render() {
    return (
      <BaseMetadataSection
        entity-type="metabolite"
        get-metadata-url={this.getMetadataUrl}
        Severity: Major
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js and 1 other location - About 2 hrs to fix
        src/scenes/BiochemicalEntityDetails/Gene/MetadataSection.js on lines 442..453

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    <li key={prop.name}>
              <b>{prop.name}:</b> {prop.value}
            </li>
        Severity: Minor
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js and 1 other location - About 50 mins to fix
        src/scenes/BiochemicalEntityDetails/Reaction/MetadataSection.js on lines 222..224

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              sections.push({
        id: "chemistry",
        title: "Chemistry",
        content: <ul className="key-value-list">{physicalProps}</ul>,
      });
        Severity: Minor
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js and 2 other locations - About 30 mins to fix
        src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js on lines 325..331
        src/scenes/BiochemicalEntityDetails/Reaction/MetadataSection.js on lines 248..252

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              sections.push({
        id: "cross-refs",
        title: "Cross references and more information",
        content: (
          <ul className="key-value-list three-col-list link-list">{dbLinks}</ul>
        Severity: Minor
        Found in src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js and 2 other locations - About 30 mins to fix
        src/scenes/BiochemicalEntityDetails/Metabolite/MetadataSection.js on lines 359..363
        src/scenes/BiochemicalEntityDetails/Reaction/MetadataSection.js on lines 248..252

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status