Sign upLogin

Katello/katello

View on GitHub
Star
webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js

Summary

Maintainability
D
1 day
Test Coverage

File AffectedRepositoryTable.js has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { useState, useCallback } from 'react';
import useDeepCompareEffect from 'use-deep-compare-effect';
import { useSelector, shallowEqual, useDispatch } from 'react-redux';
import {
  Bullseye,
Severity: Minor
Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js - About 2 hrs to fix

    Function buildRows has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const buildRows = useCallback((results) => {
    const isAddedToFilter = repoId => (!!repositories.filter(repo => repo.id === repoId).length);
    const newRows = [];
    results.forEach((repo) => {
      const {
    Severity: Minor
    Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js - About 1 hr to fix

      Function AffectedRepositoryTable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const AffectedRepositoryTable = ({
  cvId, filterId, repoType, setShowAffectedRepos, details,
}) => {
  const dispatch = useDispatch();
  const response = useSelector(state => selectCVFilterRepos(state, filterId), shallowEqual);
      Severity: Minor
      Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      AffectedRepositoryTable.propTypes = {
  cvId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
  filterId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
  repoType: PropTypes.string.isRequired,
  setShowAffectedRepos: PropTypes.func.isRequired,
      Severity: Major
      Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js and 3 other locations - About 4 hrs to fix
      webpack/scenes/ContentViews/Details/Filters/CVErrataIDFilterContent.js on lines 473..481
      webpack/scenes/ContentViews/Details/Filters/CVModuleStreamFilterContent.js on lines 306..314
      webpack/scenes/ContentViews/Details/Filters/CVPackageGroupFilterContent.js on lines 296..304

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

            {...{
        rows,
        metadata,
        emptyContentTitle,
        emptyContentBody,
      Severity: Major
      Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js and 4 other locations - About 1 hr to fix
      webpack/components/extensions/HostDetails/Tabs/TracesTab/TracesTab.js on lines 204..219
      webpack/scenes/AlternateContentSources/MainTable/ACSTable.js on lines 313..327
      webpack/scenes/ContentViews/Details/ComponentContentViews/ContentViewComponents.js on lines 244..258
      webpack/scenes/ContentViews/Details/Filters/CVErrataIDFilterContent.js on lines 261..275

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                        <ActionListItem>
                    <Dropdown
                      ouiaId="bulk-actions-dropdown"
                      toggle={<KebabToggle aria-label="bulk_actions" onToggle={toggleBulkAction} />}
                      isOpen={bulkActionOpen}
      Severity: Major
      Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js and 2 other locations - About 1 hr to fix
      webpack/components/extensions/HostDetails/Tabs/ErrataTab/ErrataTab.js on lines 374..382
      webpack/scenes/ContentViews/Details/Repositories/ContentViewRepositories.js on lines 359..367

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const dropdownItems = [
    <DropdownItem
      ouiaId="bulk-remove-dropdown-item"
      aria-label="bulk_remove"
      key="bulk_remove"
      Severity: Major
      Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js and 1 other location - About 1 hr to fix
      webpack/scenes/ContentViews/Details/Repositories/ContentViewRepositories.js on lines 287..291

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

          return newRows.sort(({ added: addedA }, { added: addedB }) => {
      if (addedA === addedB) return 0;
      return addedA ? -1 : 1;
    });
      Severity: Major
      Found in webpack/scenes/ContentViews/Details/Filters/AffectedRepositories/AffectedRepositoryTable.js and 3 other locations - About 50 mins to fix
      webpack/scenes/ContentViews/Details/Filters/CVErrataIDFilterContent.js on lines 127..130
      webpack/scenes/ContentViews/Details/Filters/CVModuleStreamFilterContent.js on lines 136..139
      webpack/scenes/ContentViews/Details/Filters/CVPackageGroupFilterContent.js on lines 128..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status