Sign upLogin

Katello/katello

View on GitHub
Star
webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

                    <SplitItem>
                      <Dropdown
                        toggle={<KebabToggle aria-label="bulk_actions" onToggle={toggleBulkAction} />}
                        isOpen={bulkActionOpen}
                        ouiaId="cv-container-image-bulk-actions"
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 4 other locations - About 4 hrs to fix
webpack/scenes/ContentViews/Details/Filters/CVErrataIDFilterContent.js on lines 339..351
webpack/scenes/ContentViews/Details/Filters/CVModuleStreamFilterContent.js on lines 273..285
webpack/scenes/ContentViews/Details/Filters/CVPackageGroupFilterContent.js on lines 263..275
webpack/scenes/ContentViews/Details/Filters/ContentViewFilters.js on lines 160..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

      {(repositories.length || showAffectedRepos) &&
        <Tab
          ouiaId="cv-container-image-affected-repos-tab"
          eventKey={1}
          title={<TabTitleText>{__('Affected repositories')}</TabTitleText>}
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 6 other locations - About 4 hrs to fix
webpack/scenes/ContentViews/Details/Filters/CVDebFilterContent.js on lines 231..240
webpack/scenes/ContentViews/Details/Filters/CVErrataDateFilterContent.js on lines 317..326
webpack/scenes/ContentViews/Details/Filters/CVErrataIDFilterContent.js on lines 458..468
webpack/scenes/ContentViews/Details/Filters/CVModuleStreamFilterContent.js on lines 291..301
webpack/scenes/ContentViews/Details/Filters/CVPackageGroupFilterContent.js on lines 281..291
webpack/scenes/ContentViews/Details/Filters/CVRpmFilterContent.js on lines 245..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const bulkRemove = () => {
    setBulkActionOpen(false);
    const tagFilterIds =
      rows.filter(row => row.selected).map(selected => selected.id);
    dispatch(deleteContentViewFilterRules(filterId, tagFilterIds, () => {
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 1 other location - About 3 hrs to fix
webpack/scenes/ContentViews/Details/Filters/CVRpmFilterContent.js on lines 141..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    {
      title: __('Remove'),
      onClick: (_event, _rowId, { id }) => {
        dispatch(removeCVFilterRule(filterId, id, () => {
          dispatch(getCVFilterRules(filterId));
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 1 other location - About 1 hr to fix
webpack/scenes/ContentViews/Details/Filters/CVRpmFilterContent.js on lines 116..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            {...{
              rows,
              metadata,
              emptyContentTitle,
              emptyContentBody,
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 4 other locations - About 1 hr to fix
webpack/scenes/ContentViews/Details/Filters/CVModuleStreamFilterContent.js on lines 217..229
webpack/scenes/ContentViews/Details/Filters/CVPackageGroupFilterContent.js on lines 207..219
webpack/scenes/ContentViews/Details/Filters/CVRpmFilterContent.js on lines 177..189
webpack/scenes/SmartProxy/SmartProxyExpandableTable.js on lines 58..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

  useEffect(() => {
    if (!repositories.length && showAffectedRepos) {
      setActiveTabKey(1);
    } else {
      setActiveTabKey(0);
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 6 other locations - About 1 hr to fix
webpack/scenes/ContentViews/Details/Filters/CVDebFilterContent.js on lines 103..109
webpack/scenes/ContentViews/Details/Filters/CVErrataDateFilterContent.js on lines 106..112
webpack/scenes/ContentViews/Details/Filters/CVErrataIDFilterContent.js on lines 150..156
webpack/scenes/ContentViews/Details/Filters/CVModuleStreamFilterContent.js on lines 161..167
webpack/scenes/ContentViews/Details/Filters/CVPackageGroupFilterContent.js on lines 153..159
webpack/scenes/ContentViews/Details/Filters/CVRpmFilterContent.js on lines 104..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  const primaryActionButton =
    (
      <Button
        ouiaId="add-content-view-container-image-filter-button"
        onClick={() => setModalOpen(true)}
Severity: Major
Found in webpack/scenes/ContentViews/Details/Filters/CVContainerImageFilterContent.js and 2 other locations - About 1 hr to fix
webpack/scenes/ContentViews/Details/Filters/CVRpmFilterContent.js on lines 153..161
webpack/scenes/ContentViews/Details/Versions/ContentViewVersions.js on lines 81..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status