Katello/katello

View on GitHub
webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js

Summary

Maintainability
C
1 day
Test Coverage

Function render has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { enabledRepositories, repositorySets, organization } = this.props;
    const { repoParams } = createEnabledRepoParams(enabledRepositories);

    if (!isEmpty(repositorySets.missingPermissions)) {
Severity: Major
Found in webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

        return (
          <Grid id="redhatRepositoriesPage" bsClass="container-fluid">
            <h1>{__('Red Hat Repositories')}</h1>
            <Row className="toolbar-pf">
              <Col sm={12}>
    Severity: Major
    Found in webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <LoadingState loading={enabledRepositories.loading} loadingText={__('Loading')}>
                    {getEnabledComponent(
                      enabledRepositories,
                      (pagination) => {
                        this.props.loadEnabledRepos({
      Severity: Major
      Found in webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js and 1 other location - About 2 hrs to fix
      webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js on lines 83..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <LoadingState loading={repositorySets.loading} loadingText={__('Loading')}>
                    {getSetsComponent(
                      repositorySets,
                      (pagination) => {
                        this.props.loadRepositorySets({
      Severity: Major
      Found in webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js and 1 other location - About 2 hrs to fix
      webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js on lines 109..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        repositorySets: PropTypes.shape({
          recommended: PropTypes.bool,
          loading: PropTypes.bool,
          search: PropTypes.shape({}),
          // Disabling rule as existing code failed due to an eslint-plugin-react update
      Severity: Major
      Found in webpack/scenes/RedHatRepositories/RedHatRepositoriesPage.js and 1 other location - About 1 hr to fix
      webpack/scenes/Subscriptions/components/SubscriptionsTable/components/Table.js on lines 101..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status