Sign upLogin

Katello/katello

View on GitHub
Star
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js

Summary

Maintainability
F
4 days
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

describe('creates ENABLE_SIMPLE_CONTENT_ACCESS_REQUEST', () => {
  const url = '/katello/api/v2/organizations/1/simple_content_access/enable';

  it('and then fails with 422', async () => {
    mockErrorRequest({
Severity: Major
Found in webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js and 4 other locations - About 6 hrs to fix
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 71..91
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 93..113
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 115..135
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 160..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe('creates UPLOAD_MANIFEST_REQUEST', () => {
    const url = '/katello/api/v2/organizations/1/subscriptions/upload';

    it('and then fails with 422', async () => {
      mockErrorRequest({
Severity: Major
Found in webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js and 4 other locations - About 6 hrs to fix
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 93..113
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 115..135
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 138..158
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 160..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe('creates REFRESH_MANIFEST_REQUEST', () => {
    const url = '/katello/api/v2/organizations/1/subscriptions/refresh_manifest';

    it('and then fails with 422', async () => {
      mockErrorRequest({
Severity: Major
Found in webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js and 4 other locations - About 6 hrs to fix
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 71..91
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 115..135
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 138..158
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 160..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

describe('creates DISABLE_SIMPLE_CONTENT_ACCESS_REQUEST', () => {
  const url = '/katello/api/v2/organizations/1/simple_content_access/disable';

  it('and then fails with 422', async () => {
    mockErrorRequest({
Severity: Major
Found in webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js and 4 other locations - About 6 hrs to fix
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 71..91
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 93..113
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 115..135
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 138..158

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe('creates DELETE_MANIFEST_REQUEST', () => {
    const url = '/katello/api/v2/organizations/1/subscriptions/delete_manifest';

    it('and then fails with 422', async () => {
      mockErrorRequest({
Severity: Major
Found in webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js and 4 other locations - About 6 hrs to fix
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 71..91
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 93..113
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 138..158
webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js on lines 160..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('and then fails with 422', async () => {
      mockErrorRequest({
        url,
        status: 422,
      });
Severity: Major
Found in webpack/scenes/Subscriptions/Manifest/__tests__/ManifestActions.test.js and 1 other location - About 1 hr to fix
webpack/scenes/Subscriptions/UpstreamSubscriptions/__tests__/UpstreamSubscriptionsActions.test.js on lines 28..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status