Sign upLogin

KentaaNL/capistrano-asg-rolling

View on GitHub
Star

Showing 2 of 2 total issues

Method validate_properties! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def validate_properties!
          raise ArgumentError, 'Property `min_healthy_percentage` must be between 0-100.' if min_healthy_percentage && !(0..100).cover?(min_healthy_percentage)

          if max_healthy_percentage
            raise ArgumentError, 'Property `max_healthy_percentage` must be between 100-200.' unless (100..200).cover?(max_healthy_percentage)
Severity: Minor
Found in lib/capistrano/asg/rolling/autoscale_group.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(id, private_ip_address, public_ip_address, image_id, autoscale_group)
Severity: Minor
Found in lib/capistrano/asg/rolling/instance.rb - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language