KnapsackPro/knapsack_pro-ruby

View on GitHub

Showing 31 of 33 total issues

Method group_test_files_by_directory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def group_test_files_by_directory
      sorted_test_files.each do |test_file|
        found = false
        DIR_TYPES.each do |type|
          if test_file['path'].match(/#{type}/)
Severity: Minor
Found in lib/knapsack_pro/test_flat_distributor.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return 'Buddy.works' if ENV.key?('BUDDY')
Severity: Major
Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return 'TeamCity' if ENV.key?('TEAMCITY_VERSION')
    Severity: Major
    Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return 'Other' if KnapsackPro::Config::Env.ci?
      Severity: Major
      Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return 'Jenkins' if ENV.key?('JENKINS_URL')
        Severity: Major
        Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return 'Google Cloud Build' if ENV.key?('BUILDER_OUTPUT')
          Severity: Major
          Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return 'Drone.io' if ENV.key?('DRONE')
            Severity: Major
            Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

              Method add_knapsack_pro_formatters_to has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def add_knapsack_pro_formatters_to(spec_opts)
                        return spec_opts unless spec_opts
                        return spec_opts if FORMATTERS.all? { |formatter| spec_opts.include?(formatter) }
              
                        FORMATTERS.each do |formatter|
              Severity: Minor
              Found in lib/knapsack_pro/pure/queue/rspec_pure.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method test_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def test_files
                    if test_file_list_enabled && KnapsackPro::Config::Env.test_file_list
                      return KnapsackPro::Config::Env.test_file_list.split(',').map(&:strip)
                    end
              
              
              Severity: Minor
              Found in lib/knapsack_pro/test_file_finder.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run_startup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run_startup(result)
                        return if @test_case.nil?
                        KnapsackPro.tracker.current_test_path = KnapsackPro::Adapters::TestUnitAdapter.test_path(self)
                        KnapsackPro.tracker.start_timer
                        return if !@test_case.respond_to?(:startup)
              Severity: Minor
              Found in lib/knapsack_pro/adapters/test_unit_adapter.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run_shutdown has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run_shutdown(result)
                        return if @test_case.nil?
                        KnapsackPro.tracker.stop_timer
                        return if !@test_case.respond_to?(:shutdown)
                        begin
              Severity: Minor
              Found in lib/knapsack_pro/adapters/test_unit_adapter.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language