Sign upLogin

KonstantinNP/php-project-lvl2

View on GitHub
Star

Showing 6 of 6 total issues

Method generateString has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateString($diffTree, $deep): string
{
    $indent = INDENT_STEP * $deep - MARKER_PLACE;
    $diffTree = is_object($diffTree) ? get_object_vars($diffTree) : $diffTree;
    $result = array_map(function ($node) use ($deep, $indent) {
Severity: Minor
Found in src/formatters/Stylish.php - About 1 hr to fix

    Function genString has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function genString($marker, $propertyArray, $value1, $value2): string
{
    if ($value1 != 'false' && $value1 != 'true' && $value1 != 'null' && !is_numeric($value1) && !is_object($value1)) {
        $value1 = "'$value1'";
    }
    Severity: Minor
    Found in src/formatters/Plain.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method genString has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function genString($marker, $propertyArray, $value1, $value2): string
{
    if ($value1 != 'false' && $value1 != 'true' && $value1 != 'null' && !is_numeric($value1) && !is_object($value1)) {
        $value1 = "'$value1'";
    }
    Severity: Minor
    Found in src/formatters/Plain.php - About 1 hr to fix

      Function getDiffArray has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function getDiffArray($diffTree): array
{
    $acc = [];
    $diffTree = is_object($diffTree) ? get_object_vars($diffTree) : $diffTree;
    foreach ($diffTree as $node) {
      Severity: Minor
      Found in src/formatters/Json.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getDiffArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getDiffArray($diffTree): array
{
    $acc = [];
    $diffTree = is_object($diffTree) ? get_object_vars($diffTree) : $diffTree;
    foreach ($diffTree as $node) {
      Severity: Minor
      Found in src/formatters/Json.php - About 1 hr to fix

        Method mkNode has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function mkNode($name, $marker, $value1, $value2, $children = [])
        Severity: Minor
        Found in src/Differ.php - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language