Sign upLogin

Kynetics/uf-android-client

View on GitHub
Star

Showing 23 of 95 total issues

Method newInstance has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        fun newInstance(context: Context,
                        countDownLatch: CountDownLatch?,
                        packageName: String?,
                        packageVersion: Long?,
                        artifact: Updater.SwModuleWithPath.Artifact?,
Severity: Major
Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/application/InstallerSession.kt - About 50 mins to fix

    Method updatePreference has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

        private fun updatePreference(preference: Preference?, key: String, sharedPrefs: SharedPreferences) {
        if (preference == null || preference is SwitchPreferenceCompat) {
            return
        }
    Severity: Minor
    Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/ui/fragment/UFPreferenceFragment.kt - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method schedule has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
    Open

        fun schedule(tag:String,
                 timeWindows: UFServiceConfigurationV2.TimeWindows,
                 action:()->Unit):Status{
        with(ExecutionTime.forCron(HaraCronParser.parse(timeWindows.cronExpression))){
            val now: ZonedDateTime = ZonedDateTime.now()
    Severity: Minor
    Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/cron/CronScheduler.kt - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language