KyperTech/matter

View on GitHub
src/index.js

Summary

Maintainability
F
3 days
Test Coverage

File index.js has 463 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import config from './config'
import logger from './utils/logger'
import * as dom from './utils/dom'
import * as request from './utils/request'
import * as ProviderAuth from './utils/providerAuth'
Severity: Minor
Found in src/index.js - About 7 hrs to fix

    Function login has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      login (loginData) {
        if (!loginData || (!isObject(loginData) && !isString(loginData))) {
          logger.error({
            description: 'Username/Email and Password are required to login',
            func: 'login', obj: 'Matter'
    Severity: Major
    Found in src/index.js - About 2 hrs to fix

      Function signup has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        signup (signupData) {
          logger.debug({
            description: 'Signup called.', signupData,
            func: 'signup', obj: 'Matter'
          })
      Severity: Major
      Found in src/index.js - About 2 hrs to fix

        Function isInGroups has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          isInGroups (checkGroups) {
            if (!this.isLoggedIn) {
              logger.log({
                description: 'No logged in user to check.',
                func: 'isInGroups', obj: 'Matter'
        Severity: Minor
        Found in src/index.js - About 1 hr to fix

          Function isInGroup has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            isInGroup (checkGroups) {
              if (!this.isLoggedIn) {
                logger.error({
                  description: 'No logged in user to check for groups.',
                  func: 'isInGroup', obj: 'Matter'
          Severity: Minor
          Found in src/index.js - About 1 hr to fix

            Function getCurrentUser has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              getCurrentUser () {
                if (this.currentUser) {
                  logger.debug({
                    description: 'Current is already available. Returning user.',
                    func: 'currentUser', obj: 'Matter'
            Severity: Minor
            Found in src/index.js - About 1 hr to fix

              Function updateAccount has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                updateAccount (updateData) {
                  if (!this.isLoggedIn) {
                    logger.error({
                      description: 'No current user profile to update.',
                      func: 'updateAccount', obj: 'Matter'
              Severity: Minor
              Found in src/index.js - About 1 hr to fix

                Function logout has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  logout () {
                    // TODO: Handle logging out of providers
                    if (!this.isLoggedIn) {
                      logger.warn({
                        description: 'No logged in account to log out.',
                Severity: Minor
                Found in src/index.js - About 1 hr to fix

                  Function authUsingProvider has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    authUsingProvider (provider) {
                      if (!provider) {
                        logger.info({
                          description: 'Provider required to sign up.',
                          func: 'authUsingProvider', obj: 'Matter'
                  Severity: Minor
                  Found in src/index.js - About 1 hr to fix

                    Function isInGroups has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                      isInGroups (checkGroups) {
                        if (!this.isLoggedIn) {
                          logger.log({
                            description: 'No logged in user to check.',
                            func: 'isInGroups', obj: 'Matter'
                    Severity: Minor
                    Found in src/index.js - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this function.
                    Open

                        return request.put(`${this.endpoint}/login`, loginData)
                        .then(response => {
                          if (response.data && response.data.status && response.data.status === 409) {
                            logger.error({
                              description: 'User not found.', response,
                    Severity: Major
                    Found in src/index.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return this.isInGroup(groupsArray[0])
                      Severity: Major
                      Found in src/index.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return this.isInGroups(checkGroups)
                        Severity: Major
                        Found in src/index.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return request.post(`${this.endpoint}/signup`, signupData).then(response => {
                                if (response.token) {
                                  this.token.string = response.token
                                }
                                if (response.user) {
                          Severity: Major
                          Found in src/index.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return false
                            Severity: Major
                            Found in src/index.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                  return false
                              Severity: Major
                              Found in src/index.js - About 30 mins to fix

                                Function isInGroup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  isInGroup (checkGroups) {
                                    if (!this.isLoggedIn) {
                                      logger.error({
                                        description: 'No logged in user to check for groups.',
                                        func: 'isInGroup', obj: 'Matter'
                                Severity: Minor
                                Found in src/index.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  login (loginData) {
                                    if (!loginData || (!isObject(loginData) && !isString(loginData))) {
                                      logger.error({
                                        description: 'Username/Email and Password are required to login',
                                        func: 'login', obj: 'Matter'
                                Severity: Minor
                                Found in src/index.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!file) {
                                      logger.error({
                                        description: 'File is required to upload Avatar.',
                                        func: 'uploadAvatar', obj: 'Matter'
                                      })
                                Severity: Major
                                Found in src/index.js and 1 other location - About 1 hr to fix
                                src/index.js on lines 150..159

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 58.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!signupData) {
                                      logger.error({
                                        description: 'Signup information is required to signup.',
                                        func: 'signup', obj: 'Matter'
                                      })
                                Severity: Major
                                Found in src/index.js and 1 other location - About 1 hr to fix
                                src/index.js on lines 489..498

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 58.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!this.isLoggedIn) {
                                      logger.error({
                                        description: 'No current user profile to update.',
                                        func: 'updateAccount', obj: 'Matter'
                                      })
                                Severity: Major
                                Found in src/index.js and 1 other location - About 1 hr to fix
                                src/index.js on lines 480..488

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!this.isLoggedIn) {
                                      logger.error({
                                        description: 'Must be logged in to upload an image.',
                                        func: 'uploadAvatar', obj: 'Matter'
                                      })
                                Severity: Major
                                Found in src/index.js and 1 other location - About 1 hr to fix
                                src/index.js on lines 430..438

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!provider) {
                                      logger.info({
                                        description: 'Provider required to sign up.',
                                        func: 'authUsingProvider', obj: 'Matter'
                                      })
                                Severity: Minor
                                Found in src/index.js and 1 other location - About 55 mins to fix
                                src/index.js on lines 542..548

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 53.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!accountData) {
                                      logger.error({
                                        description: 'Account data is required to recover an account.',
                                        func: 'recoverAccount', obj: 'Matter'
                                      })
                                Severity: Minor
                                Found in src/index.js and 1 other location - About 55 mins to fix
                                src/index.js on lines 340..346

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 53.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    return request.put(`${this.endpoint}/users/${this.currentUser.username}`, updateData)
                                    .then(response => {
                                      logger.info({
                                        description: 'Update profile request responded.',
                                        response, func: 'updateAccount', obj: 'Matter'
                                Severity: Minor
                                Found in src/index.js and 1 other location - About 50 mins to fix
                                src/utils/providerAuth.js on lines 20..40

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 51.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status