Lambda-School-Labs/allay-be

Consider simplifying this complex logical expression.

Open

  } else if (
    !req.body.password ||
    !req.body.email ||
    !req.body.track_id ||
    !req.body.first_name ||

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function checkForLoginData(req, res, next) {
  if (Object.keys(req.body).length === 0) {
    res.status(400).json({message: MISSING_BODY_INFO_ERROR});
  } else if (!req.body.email || !req.body.password) {
    res.status(400).json({message: MISSING_REQUIRED_BODY_FIELD});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function checkForCompanyData(req, res, next) {
  if (Object.keys(req.body).length === 0) {
    res.status(400).json({message: MISSING_BODY_INFO_ERROR});
  } else if (!req.body.company_name || !req.body.state_id) {
    res.status(400).json({message: MISSING_REQUIRED_BODY_FIELD});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

async function validateCompanyId({params: {companyId}}, res, next) {
  try {
    const company = await Companies.findCompanyById(companyId);
    if (!company)
      return res.status(404).json({message: COMPANY_NOT_FOUND_ERROR});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

async function validateUserId({params: {userId}}, res, next) {
  try {
    const user = await Users.findUserById(userId);
    if (!user) return res.status(404).json({message: USER_NOT_FOUND_ERROR});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

async function validateReviewId({params: {revId}}, res, next) {
  try {
    const review = await Revs.findReviewsById(revId);
    if (!review) return res.status(404).json({message: REVIEW_NOT_FOUND_ERROR});

• Read up
  Read up