Sign upLogin

Lambda-School-Labs/shopping-cart-be

View on GitHub
Star
controllers/seller/getSalesHistory.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function getSalesHistory has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function getSalesHistory (req, res) {
  try {
    const seller = req.decodedToken.sub
    const store = await Store.findOne({ seller })
Severity: Major
Found in controllers/seller/getSalesHistory.js - About 2 hrs to fix

    Function getSalesHistory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    async function getSalesHistory (req, res) {
  try {
    const seller = req.decodedToken.sub
    const store = await Store.findOne({ seller })
    Severity: Minor
    Found in controllers/seller/getSalesHistory.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Parsing error: Invalid ecmaVersion.
    Open

    const Store = require('../../models/store')
    Severity: Minor
    Found in controllers/seller/getSalesHistory.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status