Lambda-School-Labs/shopping-cart-be

View on GitHub
controllers/seller/passwordReset.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function recover has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function recover(req, res) {
    try {
        const { errors, isValid } = validateRecoverPhone(req.body);

        if (!isValid) {
Severity: Minor
Found in controllers/seller/passwordReset.js - About 1 hr to fix

    Function resetPassword has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function resetPassword(req, res) {
        try {
            const { errors, isValid } = validatePasswordResetInput(req.body);
            if (!isValid) {
                return res.status(400).json(errors);
    Severity: Minor
    Found in controllers/seller/passwordReset.js - About 1 hr to fix

      Function recover has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function recover(req, res) {
          try {
              const { errors, isValid } = validateRecoverPhone(req.body);
      
              if (!isValid) {
      Severity: Minor
      Found in controllers/seller/passwordReset.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Parsing error: Invalid ecmaVersion.
      Open

      const bcrypt = require('bcryptjs');
      Severity: Minor
      Found in controllers/seller/passwordReset.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status