Sign upLogin

Lambda-School-Labs/shopping-cart-be

View on GitHub
Star

Showing 27 of 87 total issues

Function getSalesHistory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

async function getSalesHistory (req, res) {
  try {
    const seller = req.decodedToken.sub
    const store = await Store.findOne({ seller })
Severity: Minor
Found in controllers/seller/getSalesHistory.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validatePaymentInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function validatePaymentInput (data) {
  const errors = {}
  // Convert empty fields to an empty string so we can use validator functions
  let { amount, storeId } = data
  amount = amount || ''
Severity: Minor
Found in middleware/validatePaymentData.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateRegisterInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function validateRegisterInput(data) {
    const errors = {};
    // Convert empty fields to an empty string so we can use validator functions
    data.phone = !isEmpty(data.phone) ? data.phone : '';
    data.password = !isEmpty(data.password) ? data.password : '';
Severity: Minor
Found in middleware/validateSellerData.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validatePaymentCompleteInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function validatePaymentCompleteInput (data) {
  const errors = {}
  // Convert empty fields to an empty string so we can use validator functions
  let { amount, cartId } = data
  amount = amount || ''
Severity: Minor
Found in middleware/validatePaymentComleteData.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateLoginInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function validateLoginInput(data) {
    const errors = {};
    // Convert empty fields to an empty string so we can use validator functions
    data.phone = !isEmpty(data.phone) ? data.phone : '';
    data.password = !isEmpty(data.password) ? data.password : '';
Severity: Minor
Found in middleware/validateSellerData.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function recover has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

async function recover(req, res) {
    try {
        const { errors, isValid } = validateRecoverPhone(req.body);

        if (!isValid) {
Severity: Minor
Found in controllers/seller/passwordReset.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function editStore has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

async function editStore(req, res) {
    const { sub } = req.decodedToken;
    const { businessName } = req.body;

    //   find seller / store
Severity: Minor
Found in controllers/seller/editStore.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language