Sign upLogin

LandRover/YowJS

View on GitHub
Star
test/payload.spec.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('Should be a Group Message', () => {
        let payload = new Payload(MSG_POOL.MESSAGE_GROUP_TEXT),
            messageType = payload.getMessage().getType();

        expect(messageType).to.equal(TYPES.MESSAGE_GROUP);
Severity: Major
Found in test/payload.spec.js and 5 other locations - About 3 hrs to fix
test/payload.spec.js on lines 34..40
test/payload.spec.js on lines 43..49
test/payload.spec.js on lines 52..58
test/payload.spec.js on lines 61..67
test/payload.spec.js on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('Should be a StateChanged Message for private chat', () => {
        let payload = new Payload(MSG_POOL.MESSAGE_PRIVATE_STATE_CHANGED),
            messageType = payload.getMessage().getType();

        expect(messageType).to.equal(TYPES.STATE_CHANGED);
Severity: Major
Found in test/payload.spec.js and 5 other locations - About 3 hrs to fix
test/payload.spec.js on lines 25..31
test/payload.spec.js on lines 34..40
test/payload.spec.js on lines 43..49
test/payload.spec.js on lines 52..58
test/payload.spec.js on lines 61..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('Should be a HeartBeat Message', () => {
        let payload = new Payload(MSG_POOL.MESSAGE_HEARTBEAT),
            messageType = payload.getMessage().getType();

        expect(messageType).to.equal(TYPES.HEARTBEAT);
Severity: Major
Found in test/payload.spec.js and 5 other locations - About 3 hrs to fix
test/payload.spec.js on lines 25..31
test/payload.spec.js on lines 34..40
test/payload.spec.js on lines 43..49
test/payload.spec.js on lines 61..67
test/payload.spec.js on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('Should be a StateChanged Message for group', () => {
        let payload = new Payload(MSG_POOL.MESSAGE_GROUP_STATE_CHANGED),
            messageType = payload.getMessage().getType();

        expect(messageType).to.equal(TYPES.STATE_CHANGED);
Severity: Major
Found in test/payload.spec.js and 5 other locations - About 3 hrs to fix
test/payload.spec.js on lines 25..31
test/payload.spec.js on lines 34..40
test/payload.spec.js on lines 43..49
test/payload.spec.js on lines 52..58
test/payload.spec.js on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('Should be a Private Message', () => {
        let payload = new Payload(MSG_POOL.MESSAGE_PRIVATE_TEXT),
            messageType = payload.getMessage().getType();

        expect(messageType).to.equal(TYPES.MESSAGE_PRIVATE);
Severity: Major
Found in test/payload.spec.js and 5 other locations - About 3 hrs to fix
test/payload.spec.js on lines 25..31
test/payload.spec.js on lines 43..49
test/payload.spec.js on lines 52..58
test/payload.spec.js on lines 61..67
test/payload.spec.js on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('Should be a Confirmation Message', () => {
        let payload = new Payload(MSG_POOL.MESSAGE_CONFIRMATION),
            messageType = payload.getMessage().getType();

        expect(messageType).to.equal(TYPES.CONFIRMATION);
Severity: Major
Found in test/payload.spec.js and 5 other locations - About 3 hrs to fix
test/payload.spec.js on lines 25..31
test/payload.spec.js on lines 34..40
test/payload.spec.js on lines 52..58
test/payload.spec.js on lines 61..67
test/payload.spec.js on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status