Sign upLogin

Laragear/TwoFactor

View on GitHub
Star

Showing 2 of 2 total issues

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        protected AuthManager $auth,
        protected Session $session,
        protected Request $request,
        protected string $view,
        protected string $sessionKey,
Severity: Major
Found in src/TwoFactorLoginHelper.php - About 1 hr to fix

    Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function validate(Authenticatable $user): bool
    {
        // If the user does not use 2FA or is not enabled, don't check.
        if (! $user instanceof TwoFactorAuthenticatable || ! $user->hasTwoFactorEnabled()) {
            return true;
    Severity: Minor
    Found in src/TwoFactor.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language