Laragear/WebAuthn

View on GitHub

Showing 16 of 16 total issues

ByteBuffer has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class ByteBuffer implements JsonSerializable, Jsonable, Stringable
{
    /**
     * Create a new ByteBuffer
     *
Severity: Minor
Found in src/ByteBuffer.php - About 3 hrs to fix

    AuthenticatorData has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class AuthenticatorData
    {
        // COSE encoded keys
        protected static int $COSE_KTY = 1;
        protected static int $COSE_ALG = 3;
    Severity: Minor
    Found in src/Attestation/AuthenticatorData.php - About 2 hrs to fix

      File AuthenticatorData.php has 265 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      namespace Laragear\WebAuthn\Attestation;
      
      use Laragear\WebAuthn\ByteBuffer;
      Severity: Minor
      Found in src/Attestation/AuthenticatorData.php - About 2 hrs to fix

        Method parseFloatSimple has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected static function parseFloatSimple(int $val, ByteBuffer $buf, int &$offset): bool|float|null
            {
                switch ($val) {
                    case 24:
                        $val = $buf->getByteVal($offset);
        Severity: Minor
        Found in src/CborDecoder.php - About 1 hr to fix

          Method parseExtraLength has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected static function parseExtraLength(int $val, ByteBuffer $buf, int &$offset): int
              {
                  switch ($val) {
                      case 24:
                          $val = $buf->getByteVal($offset);
          Severity: Minor
          Found in src/CborDecoder.php - About 1 hr to fix

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    public WebAuthnAuthenticatable $user,
                    public Request $request,
                    public ?Challenge $challenge = null,
                    public ?AttestationObject $attestationObject = null,
                    public ?ClientDataJson $clientDataJson = null,
            Severity: Minor
            Found in src/Attestation/Validator/AttestationValidation.php - About 45 mins to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      public Request $request,
                      public ?WebAuthnAuthenticatable $user = null,
                      public ?Challenge $challenge = null,
                      public ?WebAuthnCredential $credential = null,
                      public ?ClientDataJson $clientDataJson = null,
              Severity: Minor
              Found in src/Assertion/Validator/AssertionValidation.php - About 45 mins to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        public WebAuthnAuthenticatable $user,
                        public Request $request,
                        public ?string $residentKey = null,
                        public ?string $userVerification = null,
                        public bool $uniqueCredentials = true,
                Severity: Minor
                Found in src/Attestation/Creator/AttestationCreation.php - About 35 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          public string $relyingPartyIdHash,
                          public object $flags,
                          public int $counter,
                          public object $attestedCredentialData,
                          public array $extensionData,
                  Severity: Minor
                  Found in src/Attestation/AuthenticatorData.php - About 35 mins to fix

                    Function decodeCborBase64 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function decodeCborBase64(Request $request): array
                        {
                            try {
                                $data = CborDecoder::decode(base64_decode($request->json('response.attestationObject', '')));
                            } catch (DataException $e) {
                    Severity: Minor
                    Found in src/Attestation/Validator/Pipes/CompileAttestationObject.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                                    return $val;
                    Severity: Major
                    Found in src/CborDecoder.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return static::parseMap($buf, $offset, $val);
                      Severity: Major
                      Found in src/CborDecoder.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return static::parseItem($buf, $offset); // 1 embedded data item
                        Severity: Major
                        Found in src/CborDecoder.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return static::parseSimpleValue($val);
                          Severity: Major
                          Found in src/CborDecoder.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return static::parseArray($buf, $offset, $val);
                            Severity: Major
                            Found in src/CborDecoder.php - About 30 mins to fix

                              Function derUnsignedInteger has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  protected function derUnsignedInteger(string $bytes): string
                                  {
                                      $len = strlen($bytes);
                              
                                      // Remove leading zero bytes
                              Severity: Minor
                              Found in src/Attestation/AuthenticatorData.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language