Leuchtfeuer/locate

View on GitHub

Showing 10 of 10 total issues

Function callJudges has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function callJudges(): ?Decision
    {
        $judgements = [];
        $priorities = [];

Severity: Minor
Found in Classes/Processor/Court.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method redirectToPage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function redirectToPage(): ?RedirectResponse
    {
        $pageId = (int)($this->configuration['page'] ?? $GLOBALS['TYPO3_REQUEST']->getAttribute('routing')->getPageId());
        $targetLanguageId = (int)$this->configuration['sys_language'];
        $page = BackendUtility::getRecord('pages', $pageId, '*', '', false);
Severity: Minor
Found in Classes/Verdict/Redirect.php - About 1 hr to fix

    Function handleCookieStuff has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function handleCookieStuff()
        {
            $currentLanguageUid = $this->requestedLanguageUid;
    
            if ($this->isCookieSet()) {
    Severity: Minor
    Found in Classes/Verdict/Redirect.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addJudgement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function addJudgement(array &$judgements, array $configuration, $key, AbstractJudge $judge, array &$priorities): void
        {
            $fact = $this->facts[$configuration['fact']] ?? null;
    
            if ($fact instanceof AbstractFactProvider) {
    Severity: Minor
    Found in Classes/Processor/Court.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addJudgement has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function addJudgement(array &$judgements, array $configuration, $key, AbstractJudge $judge, array &$priorities): void
    Severity: Minor
    Found in Classes/Processor/Court.php - About 35 mins to fix

      Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run(): ?ResponseInterface
          {
              // Exclude bots from redirects
              if ((bool)($this->configuration['settings']['excludeBots'] ?? false) && class_exists('Jaybizzle\CrawlerDetect\CrawlerDetect')) {
                  $crawlerDetect = new CrawlerDetect(
      Severity: Minor
      Found in Classes/Processor/Court.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
          {
              // Not responsible if backend user is logged in or EXT:static_info_tables is not loaded.
              if (($GLOBALS['BE_USER']->user !== null && $GLOBALS['BE_USER']->user['uid'] > 0) || ExtensionManagementUtility::isLoaded('static_info_tables') === false) {
                  return $handler->handle($request);
      Severity: Minor
      Found in Classes/Middleware/PageUnavailableMiddleware.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convertIpv6 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function convertIpv6(string $ip): string
          {
              $ip = inet_pton($ip);
              $bin = '';
              $binNum = '';
      Severity: Minor
      Found in Classes/Utility/LocateUtility.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processFacts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function processFacts(): void
          {
              foreach ($this->configuration['facts'] ?? [] as $key => $className) {
                  if (!class_exists($className)) {
                      $this->logger->warning(sprintf('Class "%s" does not exist. Skip.', $className));
      Severity: Minor
      Found in Classes/Processor/Court.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function redirectToPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function redirectToPage(): ?RedirectResponse
          {
              $pageId = (int)($this->configuration['page'] ?? $GLOBALS['TYPO3_REQUEST']->getAttribute('routing')->getPageId());
              $targetLanguageId = (int)$this->configuration['sys_language'];
              $page = BackendUtility::getRecord('pages', $pageId, '*', '', false);
      Severity: Minor
      Found in Classes/Verdict/Redirect.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language