Sign upLogin

LivePersonInc/chronosjs

View on GitHub
Star
src/util/EventsUtil.js

Summary

Maintainability
B
6 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (listeners && listeners.length) {
            for (var i = 0; i < listeners.length; i++) {
                try {
                    var sameFunc = (!context && listeners[i].func === func);//If this fits the function and no context was passed
                    var sameContext = (!func && context && listeners[i].context === context);//If this fits the context and no function was passed
Severity: Critical
Found in src/util/EventsUtil.js - About 1 hr to fix

    Function unbind has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function unbind(eventObj) {
        var cmdName = eventObj.unbindObj[eventObj.attrName];
        var unBound = false;
        var updatedListeners;
    Severity: Minor
    Found in src/util/EventsUtil.js - About 1 hr to fix

      Function cloneEventData has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function cloneEventData(cloneObj) {
        var resultObj = {};
        if (cloneObj.constructor === Object) {//If this is an object
            for (var key in cloneObj) {
                //noinspection JSUnfilteredForInLoop
      Severity: Minor
      Found in src/util/EventsUtil.js - About 1 hr to fix

        Function _unbind has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function _unbind(listeners, func, context, appName) {
        var newListeners = [];
        if (listeners && listeners.length) {
            for (var i = 0; i < listeners.length; i++) {
                try {
        Severity: Minor
        Found in src/util/EventsUtil.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (cloneObj[key].constructor === Array) {
                            //noinspection JSUnfilteredForInLoop
                            resultObj[key] = cloneObj[key].slice(0) || [];
                        }
                        else { //noinspection JSUnfilteredForInLoop
          Severity: Major
          Found in src/util/EventsUtil.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if ("function" === typeof define && define.amd) {
        // AMD. Register as an anonymous module.
        define("Chronos.EventsUtil", [], function () {
            return factory(root, root, true);
        });
            Severity: Minor
            Found in src/util/EventsUtil.js and 1 other location - About 55 mins to fix
            src/courier/PostMessageUtilities.js on lines 6..13

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status