LucasAntoniassi/meteor-accounts-lockout

View on GitHub

Showing 9 of 31 total issues

File unknownUser.js has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Meteor } from 'meteor/meteor';
import { Accounts } from 'meteor/accounts-base';
import _AccountsLockoutCollection from './accountsLockoutCollection';

class UnknownUser {
Severity: Minor
Found in src/unknownUser.js - About 3 hrs to fix

    File knownUser.js has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable no-underscore-dangle */
    
    import { Meteor } from 'meteor/meteor';
    import { Accounts } from 'meteor/accounts-base';
    
    
    Severity: Minor
    Found in src/knownUser.js - About 2 hrs to fix

      UnknownUser has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class UnknownUser {
        constructor(
          settings,
          {
            AccountsLockoutCollection = _AccountsLockoutCollection,
      Severity: Minor
      Found in src/unknownUser.js - About 2 hrs to fix

        Function validateLoginAttempt has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          validateLoginAttempt(loginInfo) {
            if (
              // don't interrupt non-password logins
              loginInfo.type !== 'password' ||
              loginInfo.user === undefined ||
        Severity: Minor
        Found in src/knownUser.js - About 1 hr to fix

          Function validateLoginAttempt has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            validateLoginAttempt(loginInfo) {
              // don't interrupt non-password logins
              if (
                loginInfo.type !== 'password' ||
                loginInfo.user !== undefined ||
          Severity: Minor
          Found in src/unknownUser.js - About 1 hr to fix

            Function validateLoginAttempt has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              validateLoginAttempt(loginInfo) {
                if (
                  // don't interrupt non-password logins
                  loginInfo.type !== 'password' ||
                  loginInfo.user === undefined ||
            Severity: Minor
            Found in src/knownUser.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateLoginAttempt has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              validateLoginAttempt(loginInfo) {
                // don't interrupt non-password logins
                if (
                  loginInfo.type !== 'password' ||
                  loginInfo.user !== undefined ||
            Severity: Minor
            Found in src/unknownUser.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function scheduleUnlocksForLockedAccounts has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              scheduleUnlocksForLockedAccounts() {
                const lockedAccountsCursor = this.AccountsLockoutCollection.find(
                  {
                    'services.accounts-lockout.unlockTime': {
                      $gt: Number(new Date()),
            Severity: Minor
            Found in src/unknownUser.js - About 1 hr to fix

              Function scheduleUnlocksForLockedAccounts has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                scheduleUnlocksForLockedAccounts() {
                  const lockedAccountsCursor = Meteor.users.find(
                    {
                      'services.accounts-lockout.unlockTime': {
                        $gt: Number(new Date()),
              Severity: Minor
              Found in src/knownUser.js - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language