Sign upLogin

LudovicRousseau/PCSC

View on GitHub
Star

Showing 7 of 16 total issues

Function main has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def main():
    """docstring for main"""
    global unblocked

    RED = "\033[0;31m"
Severity: Minor
Found in UnitaryTests/SCardBlockingBehaviourTest.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def main():
    """ main """
    card_connection = readers()[0].createConnection()
    card_connection.connect(mode=SCARD_SHARE_DIRECT,
        disposition=SCARD_LEAVE_CARD)
Severity: Minor
Found in UnitaryTests/FEATURE_CCID_ESC_COMMAND_Gemalto_features.py - About 1 hr to fix

    Function switch_interface has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def switch_interface(interface):
    """
    switch from contact to contactless (or reverse) on a GemProx DU reader
    """
    for reader in readers():
    Severity: Minor
    Found in UnitaryTests/control_switch_interface.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def main():
    """ main """
    card_connection = readers()[0].createConnection()
    card_connection.connect(mode=SCARD_SHARE_DIRECT,
        disposition=SCARD_LEAVE_CARD)
    Severity: Minor
    Found in UnitaryTests/FEATURE_CCID_ESC_COMMAND_Gemalto_features.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getstatuschange has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def getstatuschange():
    # this call will be cancelled
    hresult, newstates = SCardGetStatusChange(hcontext, 10000,
            list(readerstates.values()))
    print("SCardGetStatusChange()", SCardGetErrorMessage(hresult))
    Severity: Minor
    Found in UnitaryTests/SCardCancel3.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function stress has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def stress(*args):
    """
    stress method
    """
    thread = args[0]
    Severity: Minor
    Found in UnitaryTests/ThreadSafeConnect.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                    if DDDD == 0x0020:
                    bus = (DDDDCCCC & 0xFF00) >> 8
                    addr = DDDDCCCC & 0xFF
                    print(" USB: bus: {}, addr: {}".format(bus, addr))
    Severity: Major
    Found in UnitaryTests/SCardGetAttrib.py - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language