LumberjackOtters/serverless-aws-arn-resolver

View on GitHub

Showing 9 of 21 total issues

Function getValueFromAws has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

async function getValueFromAws(slug, region, strictMode) {
  try {
    // The format is aws:${service}:${key}:${request} or aws:${service}:${subService}:${key}:${request}.
    // eg.: aws:kinesis:stream-name:StreamARN
    // Validate the input format
Severity: Minor
Found in src/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getEC2Value has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

async function getEC2Value(key, awsParameters) {
  const ec2 = new AWS.EC2({...awsParameters, apiVersion: '2015-01-01'})

  const keys = key.split(':')

Severity: Minor
Found in src/handlers.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getEC2Value has 37 lines of code (exceeds 30 allowed). Consider refactoring.
Open

async function getEC2Value(key, awsParameters) {
  const ec2 = new AWS.EC2({...awsParameters, apiVersion: '2015-01-01'})

  const keys = key.split(':')

Severity: Minor
Found in src/handlers.js - About 1 hr to fix

    Function getValueFromAws has 34 lines of code (exceeds 30 allowed). Consider refactoring.
    Open

    async function getValueFromAws(slug, region, strictMode) {
      try {
        // The format is aws:${service}:${key}:${request} or aws:${service}:${subService}:${key}:${request}.
        // eg.: aws:kinesis:stream-name:StreamARN
        // Validate the input format
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function getECSValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getECSValue(key, awsParameters) {
        winston.debug(`Resolving ElastiCache cluster with name ${key}`)
        const ecs = new AWS.ElastiCache({ ...awsParameters, apiVersion: '2015-02-02' })
      
        try {
      Severity: Minor
      Found in src/handlers.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getVPCValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getVPCValue(key, awsParameters) {
        winston.debug(`Resolving vpc with name ${key}`)
        const ec2 = new AWS.EC2({ ...awsParameters, apiVersion: '2015-01-01' })
      
        try {
      Severity: Minor
      Found in src/handlers.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getRDSValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getRDSValue(key, awsParameters) {
        winston.debug(`Resolving RDS database with name ${key}`)
        const rds = new AWS.RDS({ ...awsParameters, apiVersion: '2014-10-31' })
      
        try {
      Severity: Minor
      Found in src/handlers.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getESSValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getESSValue(key, awsParameters) {
        winston.debug(`Resolving ElasticSearch cluster with name ${key}`)
        const ess = new AWS.ES({ ...awsParameters, apiVersion: '2015-01-01' })
      
        try {
      Severity: Minor
      Found in src/handlers.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSubnetValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getSubnetValue(key, awsParameters) {
        winston.debug(`Resolving subnet with name ${key}`)
        const ec2 = new AWS.EC2({ ...awsParameters, apiVersion: '2015-01-01' })
      
        try {
      Severity: Minor
      Found in src/handlers.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language