Sign upLogin

MaazAli/phanime

View on GitHub
Star
server/methods/revisions.js

Summary

Maintainability
F
1 wk
Test Coverage

Function revisionApproved has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

    revisionApproved: function(revision) {

        // We should actually be pulling the revision from the database
        // to ensure the revision object itself hasn't been screwed up
        // during transmision. For now, we'll leave it be.
Severity: Minor
Found in server/methods/revisions.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function revisionApproved has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    revisionApproved: function(revision) {

        // We should actually be pulling the revision from the database
        // to ensure the revision object itself hasn't been screwed up
        // during transmision. For now, we'll leave it be.
Severity: Major
Found in server/methods/revisions.js - About 5 hrs to fix

    Function revisionsAnimeAddEdit has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        revisionsAnimeAddEdit: function(anime) {

        // The edited version of the anime is sent
        check(anime, AnimeRevisionsSchema);
    Severity: Minor
    Found in server/methods/revisions.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File revisions.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    Meteor.methods({
    revisionsAnimeAdd: function(anime) {

        // Ensure integerity of data
        check(anime, AnimeRevisionsSchema);
    Severity: Minor
    Found in server/methods/revisions.js - About 3 hrs to fix

      Function revisionsAnimeAddEdit has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          revisionsAnimeAddEdit: function(anime) {

        // The edited version of the anime is sent
        check(anime, AnimeRevisionsSchema);
      Severity: Major
      Found in server/methods/revisions.js - About 2 hrs to fix

        Function revisionsAnimeUpdate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            revisionsAnimeUpdate: function(anime) {

        // Ensure integerity of data
        check(anime, AnimeRevisionsSchema);
        Severity: Minor
        Found in server/methods/revisions.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                    if (error) {
                                throw new Meteor.Error(403, error.reason);
                            }
        Severity: Major
        Found in server/methods/revisions.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (error) {
                                throw new Meteor.Error(403, error.reason);
                            }
          Severity: Major
          Found in server/methods/revisions.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if (revision.content[key] === null) {
                            unsetProperties[key] = "";
                            delete revision.content[key];
                        }
            Severity: Major
            Found in server/methods/revisions.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      Alerts.insert({
            event: "revisionDeclined",
            userId: revision.userId,
            properties: {
                decisionByUsername: Meteor.user().originalUsername,
              Severity: Major
              Found in server/methods/revisions.js and 1 other location - About 6 hrs to fix
              server/methods/revisions.js on lines 477..493

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 165.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      Alerts.insert({
            event: "revisionReopened",
            userId: revision.userId,
            properties: {
                decisionByUsername: Meteor.user().originalUsername,
              Severity: Major
              Found in server/methods/revisions.js and 1 other location - About 6 hrs to fix
              server/methods/revisions.js on lines 441..457

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 165.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  Alerts.insert({
                        event: "revisionApproved",
                        userId: revision.userId,
                        properties: {
                            decisionByUsername: Meteor.user().originalUsername,
              Severity: Major
              Found in server/methods/revisions.js and 1 other location - About 6 hrs to fix
              server/methods/revisions.js on lines 406..422

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 157.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  Alerts.insert({
                        event: "revisionApproved",
                        userId: revision.userId,
                        properties: {
                            decisionByUsername: Meteor.user().originalUsername,
              Severity: Major
              Found in server/methods/revisions.js and 1 other location - About 6 hrs to fix
              server/methods/revisions.js on lines 282..298

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 157.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (uniqueCondition && Meteor.user() && !_.isEmpty(changedAttributesAnime)) {

            // console.log("Changed attributes after condition check: " + changedAttributesAnime);

            var revisionAnime = {
              Severity: Major
              Found in server/methods/revisions.js and 1 other location - About 5 hrs to fix
              packages/phanime-mal-import/server/methods/updateAnimeWithMALId.js on lines 9..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 141.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      Revisions.update({_id: revision._id}, {$set: {status: "Open", updatedAt: new Date(), decisionByUsername: Meteor.user().originalUsername, decisionByUserId: Meteor.user()._id}});
              Severity: Major
              Found in server/methods/revisions.js and 2 other locations - About 2 hrs to fix
              server/methods/revisions.js on lines 391..403
              server/methods/revisions.js on lines 438..438

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      Revisions.update({_id: revision._id}, {$set: {status: "Declined", updatedAt: new Date(), decisionByUsername: Meteor.user().originalUsername, decisionByUserId: Meteor.user()._id}});
              Severity: Major
              Found in server/methods/revisions.js and 2 other locations - About 2 hrs to fix
              server/methods/revisions.js on lines 391..403
              server/methods/revisions.js on lines 474..474

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                  Revisions.update(
                        {
                            _id: revision._id
                        }, 
                        {
              Severity: Major
              Found in server/methods/revisions.js and 2 other locations - About 2 hrs to fix
              server/methods/revisions.js on lines 438..438
              server/methods/revisions.js on lines 474..474

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status