MailOnline/VPAIDHTML5Client

View on GitHub
demo/VPAIDAdLinear.js

Summary

Maintainability
C
1 day
Test Coverage

File VPAIDAdLinear.js has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';


(function() {

Severity: Minor
Found in demo/VPAIDAdLinear.js - About 2 hrs to fix

    Function VPAIDAdLinear has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var VPAIDAdLinear = function VPAIDAdLinear() {
        this._slot = null;
        this._videoSlot = null;
    
        this._subscribers = {};
    Severity: Minor
    Found in demo/VPAIDAdLinear.js - About 1 hr to fix

      Function initAd has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      VPAIDAdLinear.prototype.initAd = function initAd(width, height, viewMode, desiredBitrate, creativeData, environmentVars) {
      Severity: Minor
      Found in demo/VPAIDAdLinear.js - About 45 mins to fix

        Function _mapNumber has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function _mapNumber(fromStart, fromEnd, toStart, toEnd, value) {
        Severity: Minor
        Found in demo/VPAIDAdLinear.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          VPAIDAdLinear.prototype.subscribe = function subscribe(handler, event, context) {
              if (!this._subscribers[event]) {
                  this._subscribers[event] = [];
              }
              this._subscribers[event].push({callback: handler, context: context});
          Severity: Major
          Found in demo/VPAIDAdLinear.js and 1 other location - About 2 hrs to fix
          test/fixtures/simpleVPAIDAd.js on lines 16..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          VPAIDAdLinear.prototype.resumeAd = function() {
              this._videoSlot.play();
              $trigger.call(this, 'AdPlaying');
          };
          Severity: Minor
          Found in demo/VPAIDAdLinear.js and 1 other location - About 45 mins to fix
          demo/VPAIDAdLinear.js on lines 151..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          VPAIDAdLinear.prototype.pauseAd = function() {
              this._videoSlot.pause();
              $trigger.call(this, 'AdPaused');
          };
          Severity: Minor
          Found in demo/VPAIDAdLinear.js and 1 other location - About 45 mins to fix
          demo/VPAIDAdLinear.js on lines 160..163

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status