Maingron/MainOS

View on GitHub

Showing 68 of 2,717 total issues

Avoid too many return statements within this function.
Open

  return "Command not defined";
Severity: Major
Found in Program Files/cmd/scripts.js - About 30 mins to fix

    Function install has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function install() {
      if(!iofs.exists(storagePath)) {
        iofs.save(storagePath, "", "t=dir", 0, 1);
      }
    
    
    Severity: Minor
    Found in Program Files/simple cookieclicker/scripts.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createNotificationIcon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function createNotificationIcon() {
      if(parent.document.getElementById("taskbarrighticons")) {
        if(!parent.document.getElementById("notifications")) {
          let notificationIconTemp = document.createElement("a");
          notificationIconTemp.id = "notifications";
    Severity: Minor
    Found in Program Files/notifications/scripts.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function explorerdofile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function explorerdofile(path, action) { // Run if program is clicked
        var fileinfos = iofs.getInfos(path);
        let filename = fileinfos.name;
        var fileending = fileinfos.ending;
    
    
    Severity: Minor
    Found in Program Files/Explorer/inner/innerexplorer.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loginUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function loginUser(name) {
        // only once document.body is loaded - temporary fix - sometimes document.body isn't loaded when browser is in background
        if(!document.body) {
            setTimeout(function() {
                loginUser(name);
    Severity: Minor
    Found in system/system_variable.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getWindowByMagic has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function getWindowByMagic(which) {
        var result;
        if(result == undefined || result == null || result == "") {
            result = getWindowByPid(which);
        }
    Severity: Minor
    Found in functions-programs.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateBottomInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function updateBottomInfo() {
        let amountFiles = 0;
        let amountDirs = 0;
    
        for(let file of filesListed) {
    Severity: Minor
    Found in Program Files/Explorer/inner/modules/bottom_info.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function register has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function register() {
        if(os?.document.getElementById("taskbar")) {
            if(!os.document.getElementById("start")) {
                let startButton = document.createElement("button");
                startButton.id = "start";
    Severity: Minor
    Found in Program Files/Explorer/Start/scripts.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language