Sign upLogin

ManageIQ/manageiq-providers-openstack

View on GitHub
Star

Showing 111 of 190 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class EventDelegate < DelegateClass(Fog::OpenStack::Event)
    include OpenstackHandle::HandledList
    include Vmdb::Logging

    SERVICE_NAME = "Event".freeze
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/openstack_handle/event_delegate.rb and 1 other location - About 20 mins to fix
lib/manageiq/providers/openstack/legacy/openstack_handle/nfv_delegate.rb on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  class StorageDelegate < DelegateClass(Fog::OpenStack::Storage)
    include OpenstackHandle::HandledList
    include Vmdb::Logging

    SERVICE_NAME = "Storage"
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/openstack_handle/storage_delegate.rb and 3 other locations - About 20 mins to fix
lib/manageiq/providers/openstack/legacy/openstack_handle/baremetal_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/introspection_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/metering_delegate.rb on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  class IntrospectionDelegate < DelegateClass(Fog::OpenStack::Introspection)
    include OpenstackHandle::HandledList
    include Vmdb::Logging

    SERVICE_NAME = "Introspection"
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/openstack_handle/introspection_delegate.rb and 3 other locations - About 20 mins to fix
lib/manageiq/providers/openstack/legacy/openstack_handle/baremetal_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/metering_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/storage_delegate.rb on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  class BaremetalDelegate < DelegateClass(Fog::OpenStack::Baremetal)
    include OpenstackHandle::HandledList
    include Vmdb::Logging

    SERVICE_NAME = "Baremetal"
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/openstack_handle/baremetal_delegate.rb and 3 other locations - About 20 mins to fix
lib/manageiq/providers/openstack/legacy/openstack_handle/introspection_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/metering_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/storage_delegate.rb on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  class MeteringDelegate < DelegateClass(Fog::OpenStack::Metering)
    include OpenstackHandle::HandledList
    include Vmdb::Logging

    SERVICE_NAME = "Metering"
Severity: Minor
Found in lib/manageiq/providers/openstack/legacy/openstack_handle/metering_delegate.rb and 3 other locations - About 20 mins to fix
lib/manageiq/providers/openstack/legacy/openstack_handle/baremetal_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/introspection_delegate.rb on lines 2..14
lib/manageiq/providers/openstack/legacy/openstack_handle/storage_delegate.rb on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                {
                  :component    => 'select',
                  :name         => 'direction',
                  :id           => 'direction',
                  :label        => _('Direction'),
Severity: Minor
Found in app/models/manageiq/providers/openstack/network_manager/security_group.rb and 1 other location - About 15 mins to fix
app/models/manageiq/providers/openstack/network_manager/security_group.rb on lines 171..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  rescue => e
    volume_name = name.presence || ems_ref
    parsed_error = parse_error_message_from_fog_response(e)

    _log.error("volume=[#{volume_name}], error: #{parsed_error}")
Severity: Minor
Found in app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume/operations.rb and 1 other location - About 15 mins to fix
app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume/operations.rb on lines 51..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                {
                  :component    => 'select',
                  :name         => 'network_protocol',
                  :id           => 'network_protocol',
                  :label        => _('Network Protocol'),
Severity: Minor
Found in app/models/manageiq/providers/openstack/network_manager/security_group.rb and 1 other location - About 15 mins to fix
app/models/manageiq/providers/openstack/network_manager/security_group.rb on lines 154..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  rescue => e
    volume_name = name.presence || ems_ref
    parsed_error = parse_error_message_from_fog_response(e)

    _log.error("volume=[#{volume_name}], error: #{parsed_error}")
Severity: Minor
Found in app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume/operations.rb and 1 other location - About 15 mins to fix
app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume/operations.rb on lines 33..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        {
          :component    => 'select',
          :name         => 'volume_type',
          :id           => 'volume_type',
          :label        => _('Cloud Volume Type'),
Severity: Minor
Found in app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume.rb and 1 other location - About 15 mins to fix
app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume.rb on lines 48..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        {
          :component    => 'select',
          :name         => 'availability_zone_id',
          :id           => 'availability_zone_id',
          :label        => _('Availability Zone'),
Severity: Minor
Found in app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume.rb and 1 other location - About 15 mins to fix
app/models/manageiq/providers/openstack/storage_manager/cinder_manager/cloud_volume.rb on lines 61..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language