Sign upLogin

ManageIQ/manageiq-providers-ovirt

View on GitHub
Star

Showing 5 of 37 total issues

Method vms has a Cognitive Complexity of 29 (exceeds 11 allowed). Consider refactoring.
Open

  def vms
    vms = Array(collector.vms) + Array(collector.templates)
    vms.compact.each do |vm|
      # Skip the place holder template
      next if vm.id == '00000000-0000-0000-0000-000000000000'
Severity: Minor
Found in app/models/manageiq/providers/ovirt/inventory/parser/infra_manager.rb - About 3 hrs to fix

Method vm_reconfigure has a Cognitive Complexity of 21 (exceeds 11 allowed). Consider refactoring.
Open

    def vm_reconfigure(vm, options = {})
      log_header = "EMS: [#{ext_management_system.name}] #{vm.class.name}: id [#{vm.id}], name [#{vm.name}], ems_ref [#{vm.ems_ref}]"
      spec = options[:spec]
 
      _log.info("#{log_header} Started...")
Severity: Minor
Found in app/models/manageiq/providers/ovirt/infra_manager/ovirt_services.rb - About 1 hr to fix

Method vm_hardware_guest_devices has a Cognitive Complexity of 21 (exceeds 11 allowed). Consider refactoring.
Open

  def vm_hardware_guest_devices(persister_hardware, vm, addresses, host)
    networks = {}
    addresses.each do |mac, address|
      network = persister.networks.lazy_find(
        :hardware    => persister_hardware,
Severity: Minor
Found in app/models/manageiq/providers/ovirt/inventory/parser/infra_manager.rb - About 1 hr to fix

Method ensure_network_manager has a Cognitive Complexity of 16 (exceeds 11 allowed). Consider refactoring.
Open

  def ensure_network_manager
    providers = ovirt_services.collect_external_network_providers
 
    unless providers.blank?
      providers = providers.sort_by(&:name)
Severity: Minor
Found in app/models/manageiq/providers/ovirt/infra_manager.rb - About 1 hr to fix

Method hardware_disks has a Cognitive Complexity of 14 (exceeds 11 allowed). Consider refactoring.
Open

  def hardware_disks(persister_hardware, disks)
    return if disks.blank?
 
    disks = Array.wrap(disks).sort_by do |disk|
      match = disk.try(:name).match(/disk[^\d]*(?<index>\d+)/i)
Severity: Minor
Found in app/models/manageiq/providers/ovirt/inventory/parser/infra_manager.rb - About 45 mins to fix
Severity
Category
Status
Source
Language