Sign upLogin

ManageIQ/manageiq-style

View on GitHub
Star

Showing 4 of 4 total issues

Method update_codeclimate_yml has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def update_codeclimate_yml(file = ".codeclimate.yml")
        data = begin
          YAML.load_file(file)
        rescue Errno::ENOENT
          {}
Severity: Minor
Found in lib/manageiq/style/cli.rb - About 1 hr to fix

    Method update_gemfile has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def update_gemfile
        contents = File.read("Gemfile")
        return if contents.include?("manageiq-style")

        lines = contents.lines
    Severity: Minor
    Found in lib/manageiq/style/cli.rb - About 1 hr to fix

      Method update_gemspec has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def update_gemspec(gemspec)
        contents = File.read(gemspec)
        return if contents.include?("manageiq-style")

        lines = contents.lines
      Severity: Minor
      Found in lib/manageiq/style/cli.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_yamllint has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def update_yamllint(file = ".yamllint")
        data = begin
          YAML.load_file(file)
        rescue Errno::ENOENT
          {}
      Severity: Minor
      Found in lib/manageiq/style/cli.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language