Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/javascript/spec/miq-alert/miq-alert.data.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const alertProfileData = {
  title: _('Belongs to Alert Profiles'),
  mode: 'miq_alert_profiles',
  message: _('This Alert is not assigned to any Alert Profiles.'),
  items: [
Severity: Major
Found in app/javascript/spec/miq-alert/miq-alert.data.js and 2 other locations - About 5 hrs to fix
app/javascript/spec/miq-condition/miq-condition.data.js on lines 31..58
app/javascript/spec/miq-alert/miq-alert.data.js on lines 121..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const alertReferencedData = {
  title: _('Referenced by Actions'),
  mode: 'miq_alert_referenced',
  message: _('This Alert is not referenced by any Actions.'),
  items: [
Severity: Major
Found in app/javascript/spec/miq-alert/miq-alert.data.js and 2 other locations - About 5 hrs to fix
app/javascript/spec/miq-condition/miq-condition.data.js on lines 31..58
app/javascript/spec/miq-alert/miq-alert.data.js on lines 92..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const expressionData = {
  title: _('Expression'),
  mode: 'miq_alert_expression',
  message: _('An alert must contain a valid expression.'),
  items: [
Severity: Major
Found in app/javascript/spec/miq-alert/miq-alert.data.js and 2 other locations - About 3 hrs to fix
app/javascript/spec/miq-condition/miq-condition.data.js on lines 9..18
app/javascript/spec/miq-condition/miq-condition.data.js on lines 20..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export const timelineData = {
  title: _('Timeline Event'),
  mode: 'miq_alert_timeline_event',
  items: [
    { label: _('Show on Timeline'), value: 'True' },
Severity: Major
Found in app/javascript/spec/miq-alert/miq-alert.data.js and 4 other locations - About 35 mins to fix
app/javascript/spec/miq-condition/miq-condition.data.js on lines 1..7
app/javascript/spec/miq-action/miq-action.data.js on lines 10..16
app/javascript/spec/miq-alert/miq-alert.data.js on lines 84..90
app/javascript/spec/miq-policy-set/miq-policy-set.data.js on lines 1..7

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export const managementData = {
  title: _('Send Management Event'),
  mode: 'miq_alert_management_event',
  items: [
    { label: _('Event Name'), value: 'Event name' },
Severity: Major
Found in app/javascript/spec/miq-alert/miq-alert.data.js and 4 other locations - About 35 mins to fix
app/javascript/spec/miq-condition/miq-condition.data.js on lines 1..7
app/javascript/spec/miq-action/miq-action.data.js on lines 10..16
app/javascript/spec/miq-alert/miq-alert.data.js on lines 76..82
app/javascript/spec/miq-policy-set/miq-policy-set.data.js on lines 1..7

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status