Sign upLogin

ManageIQ/net_app_manageability

View on GitHub
Star

Showing 5 of 19 total issues

File ontap_method_map.rb has 640 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module NetAppManageability
  module OntapMethodMap
    METHOD_MAP = {
      :aggr_add                                                => "aggr-add",
      :aggr_check_spare_low                                    => "aggr-check-spare-low",
Severity: Major
Found in lib/net_app_manageability/ontap_method_map.rb - About 1 day to fix

    Method method_missing has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def method_missing(method_name, *args)
      key = method_name.to_s.sub(/^#{STRIP_PREFIX}/, "").tr('_', '-')
      if key[-1, 1] == '='
        return (self[key[0...-1]] = args[0]) unless @sym_keys
        return (self[key[0...-1].to_sym] = args[0])
    Severity: Minor
    Found in lib/net_app_manageability/nam_hash.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method method_missing has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def method_missing(method_name, *args, &block)
      cmd = map_method(method_name.to_sym)
      return super if cmd.nil?

      ah = nil
    Severity: Minor
    Found in lib/net_app_manageability/client.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return self[key.to_sym]
    Severity: Major
    Found in lib/net_app_manageability/nam_hash.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return self[key] unless @sym_keys
      Severity: Major
      Found in lib/net_app_manageability/nam_hash.rb - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language