ManageIQ/optimist

View on GitHub

Showing 25 of 56 total issues

Avoid too many return statements within this method.
Open

          return remains += args[i..-1]
Severity: Major
Found in lib/optimist.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return remains += args[i + 1..-1]
    Severity: Major
    Found in lib/optimist.rb - About 30 mins to fix

      Method die has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def die(arg, msg = nil, error_code = nil)
          msg, error_code = nil, msg if msg.kind_of?(Integer)
          if msg
            $stderr.puts "Error: argument --#{@specs[arg].long.long} #{msg}."
          else
      Severity: Minor
      Found in lib/optimist.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method registry_getopttype has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.registry_getopttype(type)
          return nil unless type
          if type.respond_to?(:name)
            type = type.name
            lookup = type.downcase.to_sym
      Severity: Minor
      Found in lib/optimist.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.create(name, desc="", opts={}, settings={})
      
          opttype = Optimist::Parser.registry_getopttype(opts[:type])
          opttype_from_default = get_klass_from_default(opts, opttype)
      
      
      Severity: Minor
      Found in lib/optimist.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language