Marcello-Sega/pytim

View on GitHub

Showing 63 of 573 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        n_h, t_edges = np.histogram(theta, bins=bins, range=(
            0, np.pi), weights=None, density=False)
Severity: Major
Found in pytim/observables/contactangle.py and 7 other locations - About 30 mins to fix
pytim/observables/contactangle.py on lines 325..326
pytim/observables/contactangle.py on lines 337..338
pytim/observables/contactangle.py on lines 339..340
pytim/observables/contactangle.py on lines 386..387
pytim/observables/contactangle.py on lines 388..389
pytim/observables/contactangle.py on lines 390..391
pytim/observables/contactangle.py on lines 392..393

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        z_h, r_edges = np.histogram(r, bins=bins, range=(
            0, self.maxr), weights=z,    density=False)
Severity: Major
Found in pytim/observables/contactangle.py and 7 other locations - About 30 mins to fix
pytim/observables/contactangle.py on lines 323..324
pytim/observables/contactangle.py on lines 325..326
pytim/observables/contactangle.py on lines 337..338
pytim/observables/contactangle.py on lines 386..387
pytim/observables/contactangle.py on lines 388..389
pytim/observables/contactangle.py on lines 390..391
pytim/observables/contactangle.py on lines 392..393

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

            n_h_right, t_edges_right = np.histogram(
                th_right, bins=bins, range=(0, np.pi), weights=None, density=False)
Severity: Major
Found in pytim/observables/contactangle.py and 7 other locations - About 30 mins to fix
pytim/observables/contactangle.py on lines 323..324
pytim/observables/contactangle.py on lines 325..326
pytim/observables/contactangle.py on lines 337..338
pytim/observables/contactangle.py on lines 339..340
pytim/observables/contactangle.py on lines 386..387
pytim/observables/contactangle.py on lines 388..389
pytim/observables/contactangle.py on lines 392..393

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language