MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-

View on GitHub

Showing 68 of 446 total issues

Function constructor has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor() {
    let ready = true;
    this.__defineGetter__('ready', () => ready);
    this.__defineSetter__('ready', (newValue) => {
      ready = newValue;
Severity: Minor
Found in src/renderer/rendererEmitter.js - About 1 hr to fix

    Function setUpAutoUpdate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const setUpAutoUpdate = () => {
      if (global.DEV_MODE) return;
      try {
        autoUpdater.setFeedURL(`https://update.gpmdp.xyz/update/${platform}/${app.getVersion()}`);
    
    
    Severity: Minor
    Found in src/main/features/core/autoUpdater.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

      if ((osVersion[0] && parseInt(osVersion[0], 10) > 6) || (parseInt(osVersion[0], 10) === 6 && parseInt(osVersion[1], 10) > 1)) {
        // If we are above windows 7 we can use the system notifications but with
        // the silent flag forced on
        require('../silent_Notification');
      } else {
      Severity: Critical
      Found in src/renderer/generic/win32/polyfill_Notification.js - About 1 hr to fix

        Line 170 exceeds the maximum line length of 160.
        Open

              `vendor\\signtool sign /f ".cert.pfx" /p ${process.env.SIGN_CERT_PASS} /td ${signDigest} /fd ${signDigest} /tr "http://timestamp.digicert.com" /v /as "${filePath}"`,
        Severity: Minor
        Found in gulpfile.babel.js by eslint

        enforce a maximum line length (max-len)

        Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

        Rule Details

        This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

        Options

        This rule has a number or object option:

        • "code" (default 80) enforces a maximum line length
        • "tabWidth" (default 4) specifies the character width for tab characters
        • "comments" enforces a maximum line length for comments; defaults to value of code
        • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
        • "ignoreComments": true ignores all trailing comments and comments on their own line
        • "ignoreTrailingComments": true ignores only trailing comments
        • "ignoreUrls": true ignores lines that contain a URL
        • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
        • "ignoreTemplateLiterals": true ignores lines that contain a template literal
        • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

        code

        Examples of incorrect code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

        Examples of correct code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = {
          "bar": "This is a bar.",
          "baz": { "qux": "This is a qux" },
          "easier": "to read"
        };

        tabWidth

        Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

        Examples of correct code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = {
        \t  \t  \t  \t  "bar": "This is a bar.",
        \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
        \t  \t  };

        comments

        Examples of incorrect code for this rule with the { "comments": 65 } option:

        /*eslint max-len: ["error", { "comments": 65 }]*/
        
        /**
         * This is a comment that violates the maximum line length we have specified
        **/

        ignoreComments

        Examples of correct code for this rule with the { "ignoreComments": true } option:

        /*eslint max-len: ["error", { "ignoreComments": true }]*/
        
        /**
         * This is a really really really really really really really really really long comment
        **/

        ignoreTrailingComments

        Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

        /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
        
        var foo = 'bar'; // This is a really really really really really really really long comment

        ignoreUrls

        Examples of correct code for this rule with the { "ignoreUrls": true } option:

        /*eslint max-len: ["error", { "ignoreUrls": true }]*/
        
        var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

        ignoreStrings

        Examples of correct code for this rule with the { "ignoreStrings": true } option:

        /*eslint max-len: ["error", { "ignoreStrings": true }]*/
        
        var longString = 'this is a really really really really really long string!';

        ignoreTemplateLiterals

        Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
        
        var longTemplateLiteral = `this is a really really really really really long template literal!`;

        ignoreRegExpLiterals

        Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
        
        var longRegExpLiteral = /this is a really really really really really long regular expression!/;

        ignorePattern

        Examples of correct code for this rule with the { "ignorePattern": true } option:

        /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
        
        var dep = require('really/really/really/really/really/really/really/really/long/module');

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md)
        • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

        Line 102 exceeds the maximum line length of 160.
        Open

                    <header className="darwin-title-bar" onDoubleClick={this._darwinExpand} style={{ backgroundColor: muiTheme.tabs.backgroundColor, height: this.state.isFullscreen ? 0 : 23 }}>

        enforce a maximum line length (max-len)

        Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

        Rule Details

        This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

        Options

        This rule has a number or object option:

        • "code" (default 80) enforces a maximum line length
        • "tabWidth" (default 4) specifies the character width for tab characters
        • "comments" enforces a maximum line length for comments; defaults to value of code
        • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
        • "ignoreComments": true ignores all trailing comments and comments on their own line
        • "ignoreTrailingComments": true ignores only trailing comments
        • "ignoreUrls": true ignores lines that contain a URL
        • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
        • "ignoreTemplateLiterals": true ignores lines that contain a template literal
        • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

        code

        Examples of incorrect code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

        Examples of correct code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = {
          "bar": "This is a bar.",
          "baz": { "qux": "This is a qux" },
          "easier": "to read"
        };

        tabWidth

        Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

        Examples of correct code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = {
        \t  \t  \t  \t  "bar": "This is a bar.",
        \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
        \t  \t  };

        comments

        Examples of incorrect code for this rule with the { "comments": 65 } option:

        /*eslint max-len: ["error", { "comments": 65 }]*/
        
        /**
         * This is a comment that violates the maximum line length we have specified
        **/

        ignoreComments

        Examples of correct code for this rule with the { "ignoreComments": true } option:

        /*eslint max-len: ["error", { "ignoreComments": true }]*/
        
        /**
         * This is a really really really really really really really really really long comment
        **/

        ignoreTrailingComments

        Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

        /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
        
        var foo = 'bar'; // This is a really really really really really really really long comment

        ignoreUrls

        Examples of correct code for this rule with the { "ignoreUrls": true } option:

        /*eslint max-len: ["error", { "ignoreUrls": true }]*/
        
        var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

        ignoreStrings

        Examples of correct code for this rule with the { "ignoreStrings": true } option:

        /*eslint max-len: ["error", { "ignoreStrings": true }]*/
        
        var longString = 'this is a really really really really really long string!';

        ignoreTemplateLiterals

        Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
        
        var longTemplateLiteral = `this is a really really really really really long template literal!`;

        ignoreRegExpLiterals

        Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
        
        var longRegExpLiteral = /this is a really really really really really long regular expression!/;

        ignorePattern

        Examples of correct code for this rule with the { "ignorePattern": true } option:

        /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
        
        var dep = require('really/really/really/really/really/really/really/really/long/module');

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md)
        • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

        Line 17 exceeds the maximum line length of 160.
        Open

                  <a href="https://api.slack.com/custom-integrations/legacy-tokens" target="_blank" style={{ color: 'white' }}>https://api.slack.com/custom-integrations/legacy-tokens</a>)

        enforce a maximum line length (max-len)

        Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

        Rule Details

        This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

        Options

        This rule has a number or object option:

        • "code" (default 80) enforces a maximum line length
        • "tabWidth" (default 4) specifies the character width for tab characters
        • "comments" enforces a maximum line length for comments; defaults to value of code
        • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
        • "ignoreComments": true ignores all trailing comments and comments on their own line
        • "ignoreTrailingComments": true ignores only trailing comments
        • "ignoreUrls": true ignores lines that contain a URL
        • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
        • "ignoreTemplateLiterals": true ignores lines that contain a template literal
        • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

        code

        Examples of incorrect code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

        Examples of correct code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = {
          "bar": "This is a bar.",
          "baz": { "qux": "This is a qux" },
          "easier": "to read"
        };

        tabWidth

        Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

        Examples of correct code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = {
        \t  \t  \t  \t  "bar": "This is a bar.",
        \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
        \t  \t  };

        comments

        Examples of incorrect code for this rule with the { "comments": 65 } option:

        /*eslint max-len: ["error", { "comments": 65 }]*/
        
        /**
         * This is a comment that violates the maximum line length we have specified
        **/

        ignoreComments

        Examples of correct code for this rule with the { "ignoreComments": true } option:

        /*eslint max-len: ["error", { "ignoreComments": true }]*/
        
        /**
         * This is a really really really really really really really really really long comment
        **/

        ignoreTrailingComments

        Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

        /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
        
        var foo = 'bar'; // This is a really really really really really really really long comment

        ignoreUrls

        Examples of correct code for this rule with the { "ignoreUrls": true } option:

        /*eslint max-len: ["error", { "ignoreUrls": true }]*/
        
        var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

        ignoreStrings

        Examples of correct code for this rule with the { "ignoreStrings": true } option:

        /*eslint max-len: ["error", { "ignoreStrings": true }]*/
        
        var longString = 'this is a really really really really really long string!';

        ignoreTemplateLiterals

        Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
        
        var longTemplateLiteral = `this is a really really really really really long template literal!`;

        ignoreRegExpLiterals

        Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
        
        var longRegExpLiteral = /this is a really really really really really long regular expression!/;

        ignorePattern

        Examples of correct code for this rule with the { "ignorePattern": true } option:

        /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
        
        var dep = require('really/really/really/really/really/really/really/really/long/module');

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md)
        • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

        Line 54 exceeds the maximum line length of 160.
        Open

          window.GPM.on(location.host === 'music.youtube.com' || Settings.get('forceLegacyPlaybackTimeMonitoring') ? 'change:playback-time' : 'change:playback-time-internal', (playbackInfo) => {

        enforce a maximum line length (max-len)

        Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

        Rule Details

        This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

        Options

        This rule has a number or object option:

        • "code" (default 80) enforces a maximum line length
        • "tabWidth" (default 4) specifies the character width for tab characters
        • "comments" enforces a maximum line length for comments; defaults to value of code
        • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
        • "ignoreComments": true ignores all trailing comments and comments on their own line
        • "ignoreTrailingComments": true ignores only trailing comments
        • "ignoreUrls": true ignores lines that contain a URL
        • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
        • "ignoreTemplateLiterals": true ignores lines that contain a template literal
        • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

        code

        Examples of incorrect code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

        Examples of correct code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = {
          "bar": "This is a bar.",
          "baz": { "qux": "This is a qux" },
          "easier": "to read"
        };

        tabWidth

        Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

        Examples of correct code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = {
        \t  \t  \t  \t  "bar": "This is a bar.",
        \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
        \t  \t  };

        comments

        Examples of incorrect code for this rule with the { "comments": 65 } option:

        /*eslint max-len: ["error", { "comments": 65 }]*/
        
        /**
         * This is a comment that violates the maximum line length we have specified
        **/

        ignoreComments

        Examples of correct code for this rule with the { "ignoreComments": true } option:

        /*eslint max-len: ["error", { "ignoreComments": true }]*/
        
        /**
         * This is a really really really really really really really really really long comment
        **/

        ignoreTrailingComments

        Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

        /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
        
        var foo = 'bar'; // This is a really really really really really really really long comment

        ignoreUrls

        Examples of correct code for this rule with the { "ignoreUrls": true } option:

        /*eslint max-len: ["error", { "ignoreUrls": true }]*/
        
        var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

        ignoreStrings

        Examples of correct code for this rule with the { "ignoreStrings": true } option:

        /*eslint max-len: ["error", { "ignoreStrings": true }]*/
        
        var longString = 'this is a really really really really really long string!';

        ignoreTemplateLiterals

        Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
        
        var longTemplateLiteral = `this is a really really really really really long template literal!`;

        ignoreRegExpLiterals

        Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
        
        var longRegExpLiteral = /this is a really really really really really long regular expression!/;

        ignorePattern

        Examples of correct code for this rule with the { "ignorePattern": true } option:

        /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
        
        var dep = require('really/really/really/really/really/really/really/really/long/module');

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md)
        • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

        Line 9 exceeds the maximum line length of 160.
        Open

        const req = request.post(`http://mac.googleplaymusicdesktopplayer.com/upload/${process.env.TRAVIS_COMMIT}/${process.env.TRAVIS_BUILD_NUMBER}`, (err, resp, body) => {
        Severity: Minor
        Found in sig/publish-mac.js by eslint

        enforce a maximum line length (max-len)

        Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

        Rule Details

        This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

        Options

        This rule has a number or object option:

        • "code" (default 80) enforces a maximum line length
        • "tabWidth" (default 4) specifies the character width for tab characters
        • "comments" enforces a maximum line length for comments; defaults to value of code
        • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
        • "ignoreComments": true ignores all trailing comments and comments on their own line
        • "ignoreTrailingComments": true ignores only trailing comments
        • "ignoreUrls": true ignores lines that contain a URL
        • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
        • "ignoreTemplateLiterals": true ignores lines that contain a template literal
        • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

        code

        Examples of incorrect code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

        Examples of correct code for this rule with the default { "code": 80 } option:

        /*eslint max-len: ["error", 80]*/
        
        var foo = {
          "bar": "This is a bar.",
          "baz": { "qux": "This is a qux" },
          "easier": "to read"
        };

        tabWidth

        Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

        Examples of correct code for this rule with the default { "tabWidth": 4 } option:

        /*eslint max-len: ["error", 80, 4]*/
        
        \t  \t  var foo = {
        \t  \t  \t  \t  "bar": "This is a bar.",
        \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
        \t  \t  };

        comments

        Examples of incorrect code for this rule with the { "comments": 65 } option:

        /*eslint max-len: ["error", { "comments": 65 }]*/
        
        /**
         * This is a comment that violates the maximum line length we have specified
        **/

        ignoreComments

        Examples of correct code for this rule with the { "ignoreComments": true } option:

        /*eslint max-len: ["error", { "ignoreComments": true }]*/
        
        /**
         * This is a really really really really really really really really really long comment
        **/

        ignoreTrailingComments

        Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

        /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
        
        var foo = 'bar'; // This is a really really really really really really really long comment

        ignoreUrls

        Examples of correct code for this rule with the { "ignoreUrls": true } option:

        /*eslint max-len: ["error", { "ignoreUrls": true }]*/
        
        var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

        ignoreStrings

        Examples of correct code for this rule with the { "ignoreStrings": true } option:

        /*eslint max-len: ["error", { "ignoreStrings": true }]*/
        
        var longString = 'this is a really really really really really long string!';

        ignoreTemplateLiterals

        Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
        
        var longTemplateLiteral = `this is a really really really really really long template literal!`;

        ignoreRegExpLiterals

        Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

        /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
        
        var longRegExpLiteral = /this is a really really really really really long regular expression!/;

        ignorePattern

        Examples of correct code for this rule with the { "ignorePattern": true } option:

        /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
        
        var dep = require('really/really/really/really/really/really/really/really/long/module');

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md)
        • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

        Function render has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
            return (
              <SettingsTabWrapper>
                <PlatformSpecific platform="darwin">
                  <div style={{ paddingBottom: 16 }}>
        Severity: Minor
        Found in src/renderer/ui/components/settings/ThemeOptions.js - About 1 hr to fix

          Function waitForExternal has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const waitForExternal = setInterval(() => {
            if (serviceReady()) {
              clearInterval(waitForExternal);
          
              if (service === 'youtube-music') {
          Severity: Minor
          Found in src/renderer/windows/GPMWebView/index.js - About 1 hr to fix

            Function reset has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              reset() {
                this.data = {
                  playing: false,
                  song: {
                    title: null,
            Severity: Minor
            Found in src/main/utils/PlaybackAPI.js - About 1 hr to fix

              Function handleCommand has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                handleCommand(command) {
                  if (!command) return;
                  let matchedFn;
                  let matchedKey = '';
                  let fnArg;

                Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  render() {
                    const actions = [
                      <FlatButton
                        label={TranslationProvider.query('button-text-cancel-alarm')}
                        onTouchTap={this.cancel}
                Severity: Minor
                Found in src/renderer/ui/components/modals/AlarmModal.js - About 1 hr to fix

                  Function render has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    render() {
                      return (
                        <WindowContainer isMainWindow title={process.platform === 'darwin' ? this.state.title : ''} confirmClose={this._confirmCloseWindow}>
                          <div className="drag-handle-large"></div>
                          <div className={`loader ${this.state.loading ? '' : 'hidden'}`}>
                  Severity: Minor
                  Found in src/renderer/ui/pages/PlayerPage.js - About 1 hr to fix

                    Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      render() {
                        return (
                          <WindowContainer title={TranslationProvider.query('title-settings')}>
                            <Tabs style={styles.tabContainer} contentContainerStyle={styles.tab}>
                              <Tab label={TranslationProvider.query('title-settings-general')}>
                    Severity: Minor
                    Found in src/renderer/ui/pages/SettingsPage.js - About 1 hr to fix

                      Function resolveLyrics has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export const resolveLyrics = (song) => {
                        const promises = [() => attemptLyricsWikia(`${song.artist}:${song.title}`)];
                        let bracketed = song.title.match(bracketedRegex()) || [];
                      
                        // DEV: Attempt to find lyrics from wikia
                      Severity: Minor
                      Found in src/main/features/core/lyrics/index.js - About 1 hr to fix

                        Function fetchLyricsPage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          new Promise((resolve, reject) => {
                            const search = `http://www.lyricsfreak.com/search.php?a=search&type=song&q=${title.replace(/ /g, '+')}`;
                            request(search, (err, resp) => {
                              try {
                                if (err) return reject(err);
                        Severity: Minor
                        Found in src/main/features/core/lyrics/source_lyricsFreak.js - About 1 hr to fix

                          Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            render() {
                              const buttonProps = {
                                primary: true,
                              };
                              let authStatus = TranslationProvider.query('lastfm-login-not-authorized');
                          Severity: Minor
                          Found in src/renderer/ui/components/settings/tabs/LastFMTab.js - About 1 hr to fix

                            Function default has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                            export default function (fileName) {
                              const targetFileName = process.windowsStore ? `${fileName}-uwp` : fileName;
                              const DIR = path.resolve(`${(app ? app.getPath('userData') : remote.require('electron').app.getPath('userData'))}/json_store`); // eslint-disable-line
                            
                              const PATH = `${DIR}/${targetFileName}.json`;
                            Severity: Minor
                            Found in src/main/utils/_jsonCreator.js - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function toggleMainWindow has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function toggleMainWindow() {
                              // the mainWindow variable will be GC'd
                              // we must find the window ourselves
                              const win = WindowManager.getAll('main')[0];
                              if (!win) return;
                            Severity: Minor
                            Found in src/main/features/core/tray.js - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language