MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-

View on GitHub

Showing 68 of 446 total issues

Function constructor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  constructor(...args) {
    super(...args);

    this.once = true;
    const service = Settings.get('service');
Severity: Minor
Found in src/renderer/ui/pages/PlayerPage.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return false;
Severity: Major
Found in src/squirrel.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return true;
    Severity: Major
    Found in src/squirrel.js - About 30 mins to fix

      Function waitForExternal has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const waitForExternal = setInterval(() => {
        if (serviceReady()) {
          clearInterval(waitForExternal);
      
          if (service === 'youtube-music') {
      Severity: Minor
      Found in src/renderer/windows/GPMWebView/index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAppIconFileName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function getAppIconFileName() {
        let appIconFileName;
        if (process.platform === 'darwin') {
          appIconFileName = 'macTemplate.png';
        } else if (WindowManager.getWindowManagerGDMName() === 'kde-plasma') {
      Severity: Minor
      Found in src/main/features/core/tray.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setContextMenu has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const setContextMenu = (track) => {
        const contextMenu = Menu.buildFromTemplate([
          {
            label: 'Service',
            enabled: false,
      Severity: Minor
      Found in src/main/features/core/tray.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function attemptLyricsWikia has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const attemptLyricsWikia = (path) =>
        new Promise((resolve, reject) => {
          fetch(`https://lyrics.wikia.com/wiki/${path}`)
            .then((data) => data.text())
            .then((html) => {
      Severity: Minor
      Found in src/main/features/core/lyrics/source_lyricsWikia.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function attemptMetroLyrics has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const attemptMetroLyrics = (path) =>
        new Promise((resolve, reject) => {
          fetch(`http://www.metrolyrics.com/${path}.html`)
            .then((data) => data.text())
            .then((html) => {
      Severity: Minor
      Found in src/main/features/core/lyrics/source_metroLyrics.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language