Sign upLogin

MattZhao/AtRisk

View on GitHub
Star

Showing 9 of 11 total issues

Method index has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    @search_active_msg = ""
    @all_types, @all_active = Form.all_types, Form.all_active
    @selected_types = params[:types] || session[:types] || {}
    @selected_activeness = params[:activeness] || session[:activeness] || {}
Severity: Minor
Found in app/controllers/forms_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class FormsController has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class FormsController < ApplicationController
  
  # check request validaty
  before_action :authenticate_user!
  before_action :find_form, :only => [:show, :update, :destroy, :revive, :hard_delete, :edit]
Severity: Minor
Found in app/controllers/forms_controller.rb - About 2 hrs to fix

    Method change has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def change
    create_table :forms do |t|
      # default PRIMARY KEY is :id (automatically generated, and we do use it!)
      t.string :id_user # User ID (set to the UID when the user first creates the form)
    Severity: Major
    Found in db/migrate/20161017055137_create_forms.rb - About 2 hrs to fix

      File forms_controller.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class FormsController < ApplicationController
  
  # check request validaty
  before_action :authenticate_user!
  before_action :find_form, :only => [:show, :update, :destroy, :revive, :hard_delete, :edit]
      Severity: Minor
      Found in app/controllers/forms_controller.rb - About 2 hrs to fix

        Method index has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def index
    @search_active_msg = ""
    @all_types, @all_active = Form.all_types, Form.all_active
    @selected_types = params[:types] || session[:types] || {}
    @selected_activeness = params[:activeness] || session[:activeness] || {}
        Severity: Minor
        Found in app/controllers/forms_controller.rb - About 1 hr to fix

          Method handle_form has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def handle_form(type)
      lower_type = type.downcase
      respond_to do |format|
        format.html do
          check_owner_and_address
          Severity: Minor
          Found in app/controllers/forms_controller.rb - About 1 hr to fix

            Method update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def update
    @form = Form.find(params[:id])
    if @form.id_user != current_user.id.to_s and !current_user.admin
      return redirect_to '/messages/no_access'
    end
            Severity: Minor
            Found in app/controllers/forms_controller.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def index
      if not current_user.admin?
        flash[:warning] = "Error: you are not an administrator of the site."
        redirect_to forms_path
      else
            Severity: Minor
            Found in app/controllers/users_controller.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def create
    @form = Form.create(form_params)
    @form.id_user = current_user.id.to_s
    @form.form_activeness = true
            Severity: Minor
            Found in app/controllers/forms_controller.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language