Sign upLogin

MeUndies/snap

View on GitHub
Star

Showing 1 of 1 total issue

Method snoop_for_errors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def snoop_for_errors(httparty_response)
      case httparty_response.parsed_response.class.to_s
        # Snap can return response bodies in many different formats. How we look
        # for and what errors can occur are dependent on that type. For example
        # 500's mostly return raw html as a string. Pages with lists are an
Severity: Minor
Found in lib/snap/client.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language