MediaMath/t1-python

View on GitHub

Showing 51 of 132 total issues

File six.py has 671 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright (c) 2010-2017 Benjamin Peterson
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
Severity: Major
Found in terminalone/vendor/six.py - About 1 day to fix

    Function print_ has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
    Open

        def print_(*args, **kwargs):
            """The new-style print function for Python 2.4 and 2.5."""
            fp = kwargs.pop("file", sys.stdout)
            if fp is None:
                return
    Severity: Minor
    Found in terminalone/vendor/six.py - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File service.py has 442 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
    """Provides service object for T1."""
    
    from __future__ import absolute_import, division
    from collections import Iterator
    Severity: Minor
    Found in terminalone/service.py - About 6 hrs to fix

      Function fetch_resource_owner_password_token has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          def fetch_resource_owner_password_token(self, username, password,
                                                  client_id, client_secret,
                                                  environment,
                                                  realm=None,
                                                  scope=None):
      Severity: Minor
      Found in terminalone/connection.py - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _validate_form_post has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          def _validate_form_post(self, data):
              """Convert Python objects to POST values.
      
              If attribute should not be sent, remove it from the body.
              """
      Severity: Minor
      Found in terminalone/entity.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _change_access has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def _change_access(self, entity_access, id_to_change, add):
              entity_hierarchy = ['advertiser',
                                  'agency',
                                  'organization']
              if entity_access not in entity_hierarchy:
      Severity: Minor
      Found in terminalone/models/permission.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File connection.py has 257 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # -*- coding: utf-8 -*-
      """Provides connection object for T1."""
      
      from __future__ import absolute_import
      
      
      Severity: Minor
      Found in terminalone/connection.py - About 2 hrs to fix

        Function __init__ has 17 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self,
        Severity: Major
        Found in terminalone/service.py - About 2 hrs to fix

          Function get has 16 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def get(self,
          Severity: Major
          Found in terminalone/service.py - About 2 hrs to fix

            Function _construct_url has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                def _construct_url(collection, entity, child, limit):
                    """Construct URL."""
                    url = [collection, ]
                    if entity is not None:
                        url.append(str(entity))  # str so that we can use join
            Severity: Minor
            Found in terminalone/service.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _construct_params has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                def _construct_params(entity, **kwargs):
                    """Construct URL params."""
                    if entity is not None:
                        params = {}
                    else:
            Severity: Minor
            Found in terminalone/service.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _return_class has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                def _return_class(self, ent_dict,
                                  child=None, child_id=None,
                                  entity_id=None, collection=None):
                    """Generate item for new class instantiation."""
                    ent_type = ent_dict.get('_type', ent_dict.get('type'))
            Severity: Minor
            Found in terminalone/service.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _validate_json_post has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                def _validate_json_post(self, data):
                    """Convert Python objects to POST values.
            
                    If attribute should not be sent, remove it from the body.
                    """
            Severity: Minor
            Found in terminalone/entity.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __init__ has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                def __init__(self, name, old_mod, new_mod, old_attr=None, new_attr=None):
                    super(MovedAttribute, self).__init__(name)
                    if PY3:
                        if new_mod is None:
                            new_mod = name
            Severity: Minor
            Found in terminalone/vendor/six.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def get(self,
                        collection,
                        entity=None,
                        child=None,
                        limit=None,
            Severity: Minor
            Found in terminalone/service.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __setattr__ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def __setattr__(self, attribute, value):
                    if value is not None and self._pull.get(attribute) is not None:
                        try:
                            self._properties[attribute] = self._pull[attribute](value)
                        except ValueError:
            Severity: Minor
            Found in terminalone/entity.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function process_entity has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                def process_entity(cls, entity):
                    """Turn json entity into a dictionary"""
                    output = entity.copy()
                    # Hold relation objects in specific dict. T1Service instantiates the
                    # correct classes.
            Severity: Minor
            Found in terminalone/jsonparser.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function dictify_entity has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                def dictify_entity(cls, entity):
                    """Turn XML entity into a dictionary"""
                    output = entity.attrib
                    # Hold relation objects in specific dict. T1Service instantiates the
                    # correct classes.
            Severity: Minor
            Found in terminalone/xmlparser.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function save_budget_flights has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def save_budget_flights(self, data=None):
                    if data is None and self.budget_flights is None:
                        raise ClientError('No budget flights to save')
                    if data is None:
                        data = self.budget_flights
            Severity: Minor
            Found in terminalone/models/campaign.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function float_or_none has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            def float_or_none(value, null_on_none=False):
                if value is not None:
                    if isinstance(value, int):
                        value = float(value)
                    if not isinstance(value, float):
            Severity: Minor
            Found in terminalone/t1types.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language