MrBoolean/tb

View on GitHub
lib/node/number.js

Summary

Maintainability
D
2 days
Test Coverage

Function validate has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

NumberNode.prototype.validate = function validate(value, path) {
  return runValidation([
    {
      runable: this.options.greaterThan,
      validator: {
Severity: Major
Found in lib/node/number.js - About 2 hrs to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        {
          runable: this.options.greaterThan,
          validator: {
            method: expect.isGreaterThan,
            args: [value, this.options.greaterThan],
    Severity: Major
    Found in lib/node/number.js and 5 other locations - About 2 hrs to fix
    lib/node/number.js on lines 112..123
    lib/node/number.js on lines 124..135
    lib/node/number.js on lines 136..147
    lib/node/number.js on lines 148..159
    lib/node/number.js on lines 160..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        {
          runable: this.options.lowerOrEqualThan,
          validator: {
            method: expect.isLowerOrEqualThan,
            args: [value, this.options.lowerOrEqualThan],
    Severity: Major
    Found in lib/node/number.js and 5 other locations - About 2 hrs to fix
    lib/node/number.js on lines 100..111
    lib/node/number.js on lines 112..123
    lib/node/number.js on lines 124..135
    lib/node/number.js on lines 148..159
    lib/node/number.js on lines 160..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        {
          runable: this.options.greaterOrEqualThan,
          validator: {
            method: expect.isGreaterOrEqualThan,
            args: [value, this.options.greaterOrEqualThan],
    Severity: Major
    Found in lib/node/number.js and 5 other locations - About 2 hrs to fix
    lib/node/number.js on lines 100..111
    lib/node/number.js on lines 124..135
    lib/node/number.js on lines 136..147
    lib/node/number.js on lines 148..159
    lib/node/number.js on lines 160..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        {
          runable: this.options.equalTo,
          validator: {
            method: expect.isEqual,
            args: [value, this.options.equalTo],
    Severity: Major
    Found in lib/node/number.js and 5 other locations - About 2 hrs to fix
    lib/node/number.js on lines 100..111
    lib/node/number.js on lines 112..123
    lib/node/number.js on lines 124..135
    lib/node/number.js on lines 136..147
    lib/node/number.js on lines 148..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        {
          runable: this.options.strictEqualTo,
          validator: {
            method: expect.isStrictEqual,
            args: [value, this.options.strictEqualTo],
    Severity: Major
    Found in lib/node/number.js and 5 other locations - About 2 hrs to fix
    lib/node/number.js on lines 100..111
    lib/node/number.js on lines 112..123
    lib/node/number.js on lines 124..135
    lib/node/number.js on lines 136..147
    lib/node/number.js on lines 160..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        {
          runable: this.options.lowerThan,
          validator: {
            method: expect.isLowerThan,
            args: [value, this.options.lowerThan],
    Severity: Major
    Found in lib/node/number.js and 5 other locations - About 2 hrs to fix
    lib/node/number.js on lines 100..111
    lib/node/number.js on lines 112..123
    lib/node/number.js on lines 136..147
    lib/node/number.js on lines 148..159
    lib/node/number.js on lines 160..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    NumberNode.prototype.isGreaterOrEqualThan = function isGreaterOrEqualThan(value) {
      this.options.greaterOrEqualThan = value;
      return this;
    };
    Severity: Major
    Found in lib/node/number.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    NumberNode.prototype.isStrictEqualTo = function isStrictEqualTo(value) {
      this.options.strictEqualTo = value;
      return this;
    };
    Severity: Major
    Found in lib/node/number.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    NumberNode.prototype.isEqualTo = function isEqualTo(value) {
      this.options.equalTo = value;
      return this;
    };
    Severity: Major
    Found in lib/node/number.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    NumberNode.prototype.isGreaterThan = function isGreaterThan(value) {
      this.options.greaterThan = value;
      return this;
    };
    Severity: Major
    Found in lib/node/number.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    NumberNode.prototype.isLowerThan = function isLowerThan(value) {
      this.options.lowerThan = value;
      return this;
    };
    Severity: Major
    Found in lib/node/number.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    NumberNode.prototype.isLowerOrEqualThan = function isLowerOrEqualThan(value) {
      this.options.lowerOrEqualThan = value;
      return this;
    };
    Severity: Major
    Found in lib/node/number.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status