MrBoolean/tb

View on GitHub
lib/node/string.js

Summary

Maintainability
C
1 day
Test Coverage

Function validate has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

StringNode.prototype.validate = function validate(value, path) {
  var count = value.length;

  return runValidation([
    {
Severity: Major
Found in lib/node/string.js - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        {
          runable: this.options.maxLength !== null,
          validator: {
            method: expect.isGreaterThan,
            args: [count, this.options.maxLength],
    Severity: Major
    Found in lib/node/string.js and 3 other locations - About 2 hrs to fix
    lib/node/array.js on lines 91..102
    lib/node/array.js on lines 103..114
    lib/node/string.js on lines 98..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        {
          runable: this.options.minLength !== null,
          validator: {
            method: expect.isLowerOrEqualThan,
            args: [count, this.options.minLength],
    Severity: Major
    Found in lib/node/string.js and 3 other locations - About 2 hrs to fix
    lib/node/array.js on lines 91..102
    lib/node/array.js on lines 103..114
    lib/node/string.js on lines 110..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        {
          runable: this.options.regExpToBeFalsely !== null,
          validator: {
            method: expect.isRegExpFalsely,
            args: [value, this.options.regExpToBeFalsely],
    Severity: Major
    Found in lib/node/string.js and 1 other location - About 1 hr to fix
    lib/node/string.js on lines 74..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        {
          runable: this.options.regExpToBeTruly !== null,
          validator: {
            method: expect.isRegExpTruly,
            args: [value, this.options.regExpToBeTruly],
    Severity: Major
    Found in lib/node/string.js and 1 other location - About 1 hr to fix
    lib/node/string.js on lines 86..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    StringNode.prototype.regExpToBeFalsely = function regExpToBeFalsely(regEx) {
      this.options.regExpToBeFalsely = regEx;
      return this;
    };
    Severity: Major
    Found in lib/node/string.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    StringNode.prototype.regExpToBeTruly = function regExpToBeTruly(regEx) {
      this.options.regExpToBeTruly = regEx;
      return this;
    };
    Severity: Major
    Found in lib/node/string.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    StringNode.prototype.minLength = function minLength(value) {
      this.options.minLength = value;
      return this;
    };
    Severity: Major
    Found in lib/node/string.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

    StringNode.prototype.maxLength = function maxLength(value) {
      this.options.maxLength = value;
      return this;
    };
    Severity: Major
    Found in lib/node/string.js and 12 other locations - About 30 mins to fix
    lib/node/array.js on lines 54..57
    lib/node/array.js on lines 65..68
    lib/node/array.js on lines 76..79
    lib/node/number.js on lines 34..37
    lib/node/number.js on lines 45..48
    lib/node/number.js on lines 56..59
    lib/node/number.js on lines 67..70
    lib/node/number.js on lines 76..79
    lib/node/number.js on lines 85..88
    lib/node/string.js on lines 30..33
    lib/node/string.js on lines 39..42
    lib/node/string.js on lines 48..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status