Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/fdd/rule/rule.controller.js

Summary

Maintainability
F
1 wk
Test Coverage

File rule.controller.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('RuleController', function(
    $scope,
    $rootScope,
Severity: Minor
Found in myems-admin/app/controllers/fdd/rule/rule.controller.js - About 3 hrs to fix

    Function addRule has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.addRule = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/fdd/rule.model.html',
            controller: 'ModalAddRuleCtrl',
            windowClass: "animated fadeIn",
    Severity: Minor
    Found in myems-admin/app/controllers/fdd/rule/rule.controller.js - About 1 hr to fix

      Function editRule has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.editRule = function(rule) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/fdd/rule.model.html',
            controller: 'ModalEditRuleCtrl',
      Severity: Minor
      Found in myems-admin/app/controllers/fdd/rule/rule.controller.js - About 1 hr to fix

        Function importRule has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.importRule = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/common/import.html',
            controller: 'ModalImportCtrl',
            windowClass: "animated fadeIn",
        Severity: Minor
        Found in myems-admin/app/controllers/fdd/rule/rule.controller.js - About 1 hr to fix

          Function deleteRule has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.deleteRule = function(rule) {
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
          Severity: Minor
          Found in myems-admin/app/controllers/fdd/rule/rule.controller.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.updateFddCodeOptions = function () {
        if ($scope.rule.category === 'SYSTEM') {
            $scope.fddCodeOptions = ['SYSTEM01', 'SYSTEM02'];
        } else if ($scope.rule.category === 'REALTIME') {
            $scope.fddCodeOptions = ['REALTIME01', 'REALTIME02'];
            Severity: Major
            Found in myems-admin/app/controllers/fdd/rule/rule.controller.js and 1 other location - About 2 days to fix
            myems-admin/app/controllers/fdd/rule/rule.controller.js on lines 285..307

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 373.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.updateFddCodeOptions = function () {
        if ($scope.rule.category === 'SYSTEM') {
            $scope.fddCodeOptions = ['SYSTEM01', 'SYSTEM02'];
        } else if ($scope.rule.category === 'REALTIME') {
            $scope.fddCodeOptions = ['REALTIME01', 'REALTIME02'];
            Severity: Major
            Found in myems-admin/app/controllers/fdd/rule/rule.controller.js and 1 other location - About 2 days to fix
            myems-admin/app/controllers/fdd/rule/rule.controller.js on lines 323..345

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 373.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.editRule = function(rule) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/fdd/rule.model.html',
            controller: 'ModalEditRuleCtrl',
            Severity: Major
            Found in myems-admin/app/controllers/fdd/rule/rule.controller.js and 1 other location - About 2 days to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 72..112

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 358.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status