Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js

Summary

Maintainability
F
3 days
Test Coverage

File advancedreport.controller.js has 297 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('AdvancedReportController', function(
    $scope,
    $rootScope,
Severity: Minor
Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js - About 3 hrs to fix

    Function addAdvancedReport has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.addAdvancedReport = function() {

        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/advancedreport/advancedreport.model.html',
            controller: 'ModalAddAdvancedReportCtrl',
    Severity: Minor
    Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js - About 1 hr to fix

      Function editAdvancedReport has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.editAdvancedReport = function(advancedReport) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/advancedreport/advancedreport.model.html',
            controller: 'ModalEditAdvancedReportCtrl',
      Severity: Minor
      Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js - About 1 hr to fix

        Function importAdvancedReport has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.importAdvancedReport = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/common/import.html',
            controller: 'ModalImportCtrl',
            windowClass: "animated fadeIn",
        Severity: Minor
        Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js - About 1 hr to fix

          Function deleteAdvancedReport has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.deleteAdvancedReport = function(advancedReport) {
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
          Severity: Minor
          Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.editAdvancedReport = function(advancedReport) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/advancedreport/advancedreport.model.html',
            controller: 'ModalEditAdvancedReportCtrl',
            Severity: Major
            Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js and 1 other location - About 2 days to fix
            myems-admin/app/controllers/fdd/rule/rule.controller.js on lines 80..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 358.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.ok = function() {
        $scope.advancedReport.next_run_datetime=moment($scope.advancedReport.next_run_datetime).format().slice(0,19);
        $uibModalInstance.close($scope.advancedReport);
    };
            Severity: Major
            Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js and 1 other location - About 1 hr to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 289..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.ok = function() {
        $scope.advancedReport.next_run_datetime=moment($scope.advancedReport.next_run_datetime).format().slice(0,19);
        $uibModalInstance.close($scope.advancedReport);
    };
            Severity: Major
            Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js and 1 other location - About 1 hr to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 317..320

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                $scope.dtOptions = {
        locale:{
            format: 'YYYY-MM-DD HH:mm:ss',
            applyLabel: "OK",
            cancelLabel: "Cancel",
            Severity: Major
            Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js and 3 other locations - About 1 hr to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 276..287
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 283..294
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 363..374

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                $scope.dtOptions = {
        locale:{
            format: 'YYYY-MM-DD HH:mm:ss',
            applyLabel: "OK",
            cancelLabel: "Cancel",
            Severity: Major
            Found in myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js and 3 other locations - About 1 hr to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 304..315
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 283..294
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 363..374

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status