Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/category/energyitem.controller.js

Summary

Maintainability
C
1 day
Test Coverage

Function editEnergyItem has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.editEnergyItem=function(energyItem){
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/category/energyitem.model.html',
            controller: 'ModalEditEnergyItemCtrl',
Severity: Minor
Found in myems-admin/app/controllers/settings/category/energyitem.controller.js - About 1 hr to fix

    Function addEnergyItem has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.addEnergyItem = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/category/energyitem.model.html',
            controller: 'ModalAddEnergyItemCtrl',
            windowClass: "animated fadeIn",
    Severity: Minor
    Found in myems-admin/app/controllers/settings/category/energyitem.controller.js - About 1 hr to fix

      Function deleteEnergyItem has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.deleteEnergyItem=function(energyItem){
        SweetAlert.swal({
            title: $translate.instant("SWEET.TITLE"),
            text: $translate.instant("SWEET.TEXT"),
            type: "warning",
      Severity: Minor
      Found in myems-admin/app/controllers/settings/category/energyitem.controller.js - About 1 hr to fix

        Similar blocks of code found in 24 locations. Consider refactoring.
        Open

        app.controller('ModalAddEnergyItemCtrl', function ($scope, $uibModalInstance,params) {

    $scope.operation="SETTING.ADD_ENERGY_ITEM";
    $scope.energyItems=params.energyItems;
    $scope.categories=params.categories;
        Severity: Major
        Found in myems-admin/app/controllers/settings/category/energyitem.controller.js and 23 other locations - About 4 hrs to fix
        myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 161..173
        myems-admin/app/controllers/settings/command/command.controller.js on lines 267..279
        myems-admin/app/controllers/settings/contact/contact.controller.js on lines 158..170
        myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 152..164
        myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 156..168
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js on lines 178..190
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 215..227
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 210..222
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 207..219
        myems-admin/app/controllers/settings/gateway/gateway.controller.js on lines 253..264
        myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 215..227
        myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 207..219
        myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 207..219
        myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 210..222
        myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 212..224
        myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 207..219
        myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 208..220
        myems-admin/app/controllers/settings/photovoltaicpowerstation/photovoltaicpowerstation.controller.js on lines 273..285
        myems-admin/app/controllers/settings/sensor/sensor.controller.js on lines 254..265
        myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 281..293
        myems-admin/app/controllers/settings/virtualpowerplant/virtualpowerplant.controller.js on lines 274..287
        myems-admin/app/controllers/settings/windfarm/windfarm.controller.js on lines 273..285
        myems-admin/app/controllers/settings/workingcalendar/workingcalendar.controller.js on lines 253..264

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if($scope.energyItem.energy_category!=null){
        $scope.energyItem.energy_category_id=$scope.energyItem.energy_category.id ;
      }else{
        $scope.energyItem.energy_category_id=undefined;
      }
        Severity: Major
        Found in myems-admin/app/controllers/settings/category/energyitem.controller.js and 1 other location - About 1 hr to fix
        myems-admin/app/controllers/users/user/user.controller.js on lines 395..399

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status