Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/command/command.controller.js

Summary

Maintainability
F
3 days
Test Coverage

File command.controller.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('CommandController', function(
    $scope,
    $rootScope,
Severity: Minor
Found in myems-admin/app/controllers/settings/command/command.controller.js - About 2 hrs to fix

    Function editCommand has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.editCommand=function(command){
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/command/command.model.html',
            controller: 'ModalEditCommandCtrl',
    Severity: Minor
    Found in myems-admin/app/controllers/settings/command/command.controller.js - About 1 hr to fix

      Function importCommand has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.importCommand = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/common/import.html',
            controller: 'ModalImportCtrl',
            windowClass: "animated fadeIn",
      Severity: Minor
      Found in myems-admin/app/controllers/settings/command/command.controller.js - About 1 hr to fix

        Function deleteCommand has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.deleteCommand=function(command){
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
        Severity: Minor
        Found in myems-admin/app/controllers/settings/command/command.controller.js - About 1 hr to fix

          Function addCommand has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.addCommand = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/command/command.model.html',
            controller: 'ModalAddCommandCtrl',
            windowClass: "animated fadeIn",
          Severity: Minor
          Found in myems-admin/app/controllers/settings/command/command.controller.js - About 1 hr to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                $scope.addCommand = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/command/command.model.html',
            controller: 'ModalAddCommandCtrl',
            windowClass: "animated fadeIn",
            Severity: Major
            Found in myems-admin/app/controllers/settings/command/command.controller.js and 3 other locations - About 1 day to fix
            myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 24..55
            myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js on lines 27..58
            myems-admin/app/controllers/settings/svg/svg.controller.js on lines 27..58

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 328.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 24 locations. Consider refactoring.
            Open

            app.controller('ModalEditCommandCtrl', function ($scope, $uibModalInstance, params) {
    $scope.operation="SETTING.EDIT_COMMAND";
    $scope.command = params.command;
    $scope.commands=params.commands;
            Severity: Major
            Found in myems-admin/app/controllers/settings/command/command.controller.js and 23 other locations - About 4 hrs to fix
            myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 161..173
            myems-admin/app/controllers/settings/category/energyitem.controller.js on lines 164..175
            myems-admin/app/controllers/settings/contact/contact.controller.js on lines 158..170
            myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 152..164
            myems-admin/app/controllers/settings/distributionsystem/distributionsystem.controller.js on lines 268..280
            myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 156..168
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 448..460
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js on lines 286..297
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 373..385
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerhvac.controller.js on lines 395..406
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 365..377
            myems-admin/app/controllers/settings/gateway/gateway.controller.js on lines 253..264
            myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 215..227
            myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 207..219
            myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 207..219
            myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 210..222
            myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 212..224
            myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 207..219
            myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 208..220
            myems-admin/app/controllers/settings/protocol/protocol.controller.js on lines 253..264
            myems-admin/app/controllers/settings/sensor/sensor.controller.js on lines 254..265
            myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 281..293
            myems-admin/app/controllers/settings/workingcalendar/workingcalendar.controller.js on lines 253..264

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 119.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            app.controller('ModalAddCommandCtrl', function ($scope, $uibModalInstance) {
    $scope.operation="SETTING.ADD_COMMAND";
    $scope.ok = function () {
        $uibModalInstance.close($scope.command);
    };
            Severity: Major
            Found in myems-admin/app/controllers/settings/command/command.controller.js and 3 other locations - About 2 hrs to fix
            myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 141..150
            myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js on lines 232..241
            myems-admin/app/controllers/settings/svg/svg.controller.js on lines 233..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 88.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status